Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continue in monitor mode when sync timed out #265

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

norbusan
Copy link
Collaborator

@norbusan norbusan commented Dec 3, 2018

Currently, if a sync times out the program exits.
Instead of exiting re-throw the exception, and let the sync routine
in the monitor section catch the error, warn, and continue.

With this, onedrive recovers after connection error:

Dec 03 10:17:41 bulldog onedrive[30277]: Syncing changes from OneDrive ...
Dec 03 10:18:31 bulldog onedrive[30277]: Syncing changes from OneDrive ...
Dec 03 10:23:32 bulldog onedrive[30277]: Access to the Microsoft OneDrive service timed out - Internet connectivity issue?
Dec 03 10:23:32 bulldog onedrive[30277]: Timeout was reached on handle 555CE1645CF0
Dec 03 10:23:32 bulldog onedrive[30277]: Syncing changes from OneDrive ...

Currently, if a sync times out the program exits.
Instead of exiting re-throw the exception, and let the sync routine
in the monitor section catch the error, warn, and continue.

With this, onedrive recovers after connection error:

Dec 03 10:17:41 bulldog onedrive[30277]: Syncing changes from OneDrive ...
Dec 03 10:18:31 bulldog onedrive[30277]: Syncing changes from OneDrive ...
Dec 03 10:23:32 bulldog onedrive[30277]: Access to the Microsoft OneDrive service timed out - Internet connectivity issue?
Dec 03 10:23:32 bulldog onedrive[30277]: Timeout was reached on handle 555CE1645CF0
Dec 03 10:23:32 bulldog onedrive[30277]: Syncing changes from OneDrive ...
@abraunegg
Copy link
Owner

@norbusan
Looks good to me

@abraunegg abraunegg merged commit 9817104 into abraunegg:master Dec 3, 2018
@norbusan norbusan deleted the graceful-monitor branch December 3, 2018 03:25
@norbusan
Copy link
Collaborator Author

norbusan commented Dec 3, 2018

Thanks a lot!

@norbusan norbusan restored the graceful-monitor branch December 3, 2018 07:26
@norbusan norbusan deleted the graceful-monitor branch December 3, 2018 07:28
@lock
Copy link

lock bot commented Jan 5, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jan 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants