Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for supported version of D compiler #545

Merged
merged 4 commits into from
Jun 18, 2019
Merged

Check for supported version of D compiler #545

merged 4 commits into from
Jun 18, 2019

Conversation

norbusan
Copy link
Collaborator

check against minimal needed version of ldc/dmd compilers
only the first three numbers are compared as numbers, everything after
that is string compared

The check can be disabled with --disable-version-check

check against minimal needed version of ldc/dmd compilers
only the first three numbers are compared as numbers, everything after
that is string compared
* Update Travis CI to download minimum version of DMD for x32 build testing
@abraunegg
Copy link
Owner

@norbusan
So the x32 build is failing due to this:

checking for a BSD-compatible install... /usr/bin/install -c
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for dmd... /home/travis/build/abraunegg/onedrive/dlang-x32/linux/bin32/dmd
checking version of D compiler... 2.081.1
./configure: line 412: test: current: integer expression expected
configure: error: compiler
./configure: line 301: return: current: numeric argument required
./configure: line 311: exit: current: numeric argument required
The command "bash -ex .travis-ci.sh" exited with 2.

Updating the Travis CI script to 2.083.1

@abraunegg
Copy link
Owner

@norbusan
OK - the update to the Travis CI script did the trick - tho - if the version is 'old' will it 'barf' as per the output above or fail with a better error ... will have to do some testing locally

abraunegg
abraunegg previously approved these changes Jun 18, 2019
@norbusan
Copy link
Collaborator Author

Strange ... very strange. I need to try to trick some old version ... please wait.

@norbusan
Copy link
Collaborator Author

Fixed ... forgot the [ ] around the error message. Now it does:

$ ./configure
checking for a BSD-compatible install... /usr/bin/install -c
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for dmd... dmd
checking version of D compiler... 2.081.1
configure: error: Compiler version insufficient, current compiler version 2.081.1, minimum version 2.083.1
$

@norbusan
Copy link
Collaborator Author

Please adjust wording if necessary @abraunegg

@abraunegg
Copy link
Owner

LGTM

@abraunegg abraunegg self-requested a review June 18, 2019 07:29
@norbusan norbusan merged commit 0961202 into master Jun 18, 2019
@norbusan norbusan deleted the dc-version branch June 18, 2019 08:39
@lock
Copy link

lock bot commented Jul 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Jul 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants