-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: multiple kubel buffers #114
Feature: multiple kubel buffers #114
Conversation
(sorry i'm super behind on this. I still intend to test and merge when I can. thank you for submitting) |
Ya, these change should be careful tested before merging |
Thank you for your patience. I just did a full test of the major pathways that this touches and it's looking great. I really like the switch buffer method you implemented. The only thing I found is duplicated code throwing an error in I can patch that for you (and also fix the conflicts) or you can do it. Up to you. But as things are, we could merge before new year. In any case, happy holidays! |
Thank you, looks like you've got some free time before the holidays 😄
Yes, sure. I need your help. Could not be better.
Happy holidays, you too! |
It's a christmas miracle! 🥳 |
This is probably intended behavior, but each time I now change namespace, context, resource it creates a new buffer, the problem is that the old one is still there. I use Edit: I do like the |
I want to say this is feature even seems you do not like it :(.
Yes, it actually exits the current buffer. What is the behaviour you want to expect? Or any feature you want, like a function |
Yeah I admit this feature changes pretty drastically how kubel behaves but I personally love it. Looking at how it was implemented, a toggle to revert back to the old behavior is possible but not trivial. I would encourage you to play around with the new behavior and as @TxGVNN suggested, if there's a specific function that would help, please let us know. |
The What is the behaviour you want to expect from @TxGVNN is a really good question! I think maybe I just got caught of guard with the new feature. And I would like to play around more with it. I've used the I'll also play with the code a bit, as I think what I would like is the possibility to just toggle new buffer when I deliberated choose so, for example by pressing |
I got inspired to play around a little bit yesterday, and by just changing (for each cluster, namespace, resource):
to
it allows me to create a new |
Hi @Kyrremann ,
What do you think? |
Totally forgot to follow up here. I agree with 2. that it will inflate the problem are for |
Continue on topic #96.
After discussing at #112 and base on the idea/code of #57. Thanks to Diego Alvarez
In #57, each time I run
kubel
, it always create a new on buffer with a same buffer name (ya, with a suffix number) and if we want to create multi buffer we have to run multi time ofkubel
, pretty annoy to me.I resolved these issues by
(clone-buffer)
to clone the local var and rename later when we switch recourse, namespaces...And I added a new interactive function
kubel-switch-to-buffer
to switch to only kubel's buffer by using prefix nameHi @abrochard, @d1egoaz. Could you guys take a review and test? Thanks