-
Notifications
You must be signed in to change notification settings - Fork 76
/
abrt-action-save-package-data.c
437 lines (377 loc) · 13.6 KB
/
abrt-action-save-package-data.c
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
/*
Copyright (C) 2009 Zdenek Prikryl (zprikryl@redhat.com)
Copyright (C) 2009 RedHat inc.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License along
with this program; if not, write to the Free Software Foundation, Inc.,
51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
*/
#include <fnmatch.h>
#include "libabrt.h"
#include "rpm.h"
static bool settings_bOpenGPGCheck = false;
static GList *settings_setOpenGPGPublicKeys = NULL;
static GList *settings_setBlackListedPkgs = NULL;
static GList *settings_setBlackListedPaths = NULL;
static bool settings_bProcessUnpackaged = false;
static GList *parse_list(const char* list)
{
struct strbuf *item = strbuf_new();
GList *l = NULL;
char *trim_item = NULL;
for (unsigned ii = 0; list[ii]; ii++)
{
if (list[ii] == ',')
{
trim_item = strtrim(item->buf);
l = g_list_append(l, xstrdup(trim_item));
strbuf_clear(item);
}
else
strbuf_append_char(item, list[ii]);
}
if (item->len > 0)
{
trim_item = strtrim(item->buf);
l = g_list_append(l, xstrdup(trim_item));
}
strbuf_free(item);
return l;
}
static void ParseCommon(map_string_t *settings, const char *conf_filename)
{
const char *value;
value = get_map_string_item_or_NULL(settings, "OpenGPGCheck");
if (value)
{
settings_bOpenGPGCheck = string_to_bool(value);
remove_map_string_item(settings, "OpenGPGCheck");
}
value = get_map_string_item_or_NULL(settings, "BlackList");
if (value)
{
settings_setBlackListedPkgs = parse_list(value);
remove_map_string_item(settings, "BlackList");
}
value = get_map_string_item_or_NULL(settings, "BlackListedPaths");
if (value)
{
settings_setBlackListedPaths = parse_list(value);
remove_map_string_item(settings, "BlackListedPaths");
}
value = get_map_string_item_or_NULL(settings, "ProcessUnpackaged");
if (value)
{
settings_bProcessUnpackaged = string_to_bool(value);
remove_map_string_item(settings, "ProcessUnpackaged");
}
map_string_iter_t iter;
const char *name;
/*char *value; - already declared */
init_map_string_iter(&iter, settings);
while (next_map_string_iter(&iter, &name, &value))
{
error_msg("Unrecognized variable '%s' in '%s'", name, conf_filename);
}
}
static void load_gpg_keys(void)
{
FILE *fp = fopen(CONF_DIR"/gpg_keys", "r");
if (fp)
{
/* every line is one key
* FIXME: make it more robust, it doesn't handle comments
*/
char *line;
while ((line = xmalloc_fgetline(fp)) != NULL)
{
if (line[0] == '/') // probably the beginning of a path, so let's handle it as a key
settings_setOpenGPGPublicKeys = g_list_append(settings_setOpenGPGPublicKeys, line);
else
free(line);
}
fclose(fp);
}
}
static int load_conf(const char *conf_filename)
{
map_string_t *settings = new_map_string();
if (!load_conf_file(conf_filename, settings, /*skip key w/o values:*/ false))
error_msg("Can't open '%s'", conf_filename);
ParseCommon(settings, conf_filename);
free_map_string(settings);
load_gpg_keys();
return 0;
}
/**
* Returns the first full path argument in the command line or NULL.
* Skips options (params of the form "-XXX").
* Returns malloc'ed string.
* NB: the cmdline is delimited by (single, not multiple) spaces, not tabs!
* "abc def\t123" means there are two params: "abc", "def\t123".
* "abc def" means there are three params: "abc", "", "def".
*/
static char *get_argv1_if_full_path(const char* cmdline)
{
const char *argv1 = strchr(cmdline, ' ');
while (argv1 != NULL)
{
/* we found space in cmdline, so it might contain
* path to some script like:
* /usr/bin/python [-XXX] /usr/bin/system-control-network
*/
argv1++; /* skip the space */
if (*argv1 != '-')
break;
/* looks like -XXX in "perl -XXX /usr/bin/script.pl", skipping */
argv1 = strchr(argv1, ' ');
}
/* if the string following the space doesn't start
* with '/', it is not a full path to script
* and we can't use it to determine the package name
*/
if (argv1 == NULL || *argv1 != '/')
return NULL;
/* good, it has "/foo/bar" form, return it */
int len = strchrnul(argv1, ' ') - argv1;
return xstrndup(argv1, len);
}
static bool is_path_blacklisted(const char *path)
{
GList *li;
for (li = settings_setBlackListedPaths; li != NULL; li = g_list_next(li))
{
if (fnmatch((char*)li->data, path, /*flags:*/ 0) == 0)
{
return true;
}
}
return false;
}
static struct pkg_envra *get_script_name(const char *cmdline, char **executable)
{
// TODO: we don't verify that python executable is not modified
// or that python package is properly signed
// (see CheckFingerprint/CheckHash below)
/* Try to find package for the script by looking at argv[1].
* This will work only if the cmdline contains the whole path.
* Example: python /usr/bin/system-control-network
*/
struct pkg_envra *script_pkg = NULL;
char *script_name = get_argv1_if_full_path(cmdline);
if (script_name)
{
script_pkg = rpm_get_package_nvr(script_name, NULL);
if (script_pkg)
{
/* There is a well-formed script name in argv[1],
* and it does belong to some package.
* Replace executable
* with data pertaining to the script.
*/
*executable = script_name;
}
}
return script_pkg;
}
static int SavePackageDescriptionToDebugDump(const char *dump_dir_name)
{
struct dump_dir *dd = dd_opendir(dump_dir_name, /*flags:*/ 0);
if (!dd)
return 1;
char *analyzer = dd_load_text(dd, FILENAME_ANALYZER);
if (!strcmp(analyzer, "Kerneloops"))
{
dd_save_text(dd, FILENAME_PACKAGE, "kernel");
dd_save_text(dd, FILENAME_COMPONENT, "kernel");
dd_close(dd);
free(analyzer);
return 0;
}
free(analyzer);
char *cmdline = NULL;
char *executable = NULL;
char *rootdir = NULL;
char *script_name = NULL; /* only if "interpreter /path/to/script" */
char *package_short_name = NULL;
struct pkg_envra *pkg_name = NULL;
char *component = NULL;
int error = 1;
/* note: "goto ret" statements below free all the above variables,
* but they don't dd_close(dd) */
cmdline = dd_load_text(dd, FILENAME_CMDLINE);
executable = dd_load_text(dd, FILENAME_EXECUTABLE);
rootdir = dd_load_text_ext(dd, FILENAME_ROOTDIR,
DD_FAIL_QUIETLY_ENOENT | DD_LOAD_TEXT_RETURN_NULL_ON_FAILURE);
/* Close dd while we query package database. It can take some time,
* don't want to keep dd locked longer than necessary */
dd_close(dd);
if (is_path_blacklisted(executable))
{
log("Blacklisted executable '%s'", executable);
goto ret; /* return 1 (failure) */
}
pkg_name = rpm_get_package_nvr(executable, rootdir);
if (!pkg_name)
{
if (settings_bProcessUnpackaged)
{
VERB2 log("Crash in unpackaged executable '%s', proceeding without packaging information", executable);
goto ret0; /* no error */
}
log("Executable '%s' doesn't belong to any package"
" and ProcessUnpackaged is set to 'no'",
executable
);
goto ret; /* return 1 (failure) */
}
/* Check well-known interpreter names */
{
const char *basename = strrchr(executable, '/');
if (basename) basename++; else basename = executable;
/* Add more interpreters as needed */
if (strcmp(basename, "python") == 0
|| strcmp(basename, "perl") == 0
) {
// TODO: we don't verify that python executable is not modified
// or that python package is properly signed
// (see CheckFingerprint/CheckHash below)
/* Try to find package for the script by looking at argv[1].
* This will work only if the cmdline contains the whole path.
* Example: python /usr/bin/system-control-network
*/
struct pkg_envra *script_pkg = get_script_name(cmdline, &executable);
/* executable may have changed, check it again */
if (is_path_blacklisted(executable))
{
log("Blacklisted executable '%s'", executable);
goto ret; /* return 1 (failure) */
}
if (!script_pkg)
{
/* Script name is not absolute, or it doesn't
* belong to any installed package.
*/
if (!settings_bProcessUnpackaged)
{
log("Interpreter crashed, but no packaged script detected: '%s'", cmdline);
goto ret; /* return 1 (failure) */
}
/* Unpackaged script, but the settings says we want to keep it.
* BZ plugin wont allow to report this anyway, because component
* is missing, so there is no reason to mark it as not_reportable.
* Someone might want to use abrt to report it using ftp.
*/
goto ret0;
}
free_pkg_envra(pkg_name);
pkg_name = script_pkg;
}
package_short_name = xasprintf("%s", pkg_name->p_name);
VERB1 log("Package:'%s' short:'%s'", pkg_name->p_nvr, package_short_name);
GList *li;
for (li = settings_setBlackListedPkgs; li != NULL; li = g_list_next(li))
{
if (strcmp((char*)li->data, package_short_name) == 0)
{
log("Blacklisted package '%s'", package_short_name);
goto ret; /* return 1 (failure) */
}
}
if (settings_bOpenGPGCheck)
{
if (!rpm_chk_fingerprint(package_short_name))
{
log("Package '%s' isn't signed with proper key", package_short_name);
goto ret; /* return 1 (failure) */
}
/* We used to also check the integrity of the executable here:
* if (!CheckHash(package_short_name.c_str(), executable)) BOOM();
* Checking the MD5 sum requires to run prelink to "un-prelink" the
* binaries - this is considered potential security risk so we don't
* do it now, until we find some non-intrusive way.
*/
}
component = rpm_get_component(executable, rootdir);
dd = dd_opendir(dump_dir_name, /*flags:*/ 0);
if (!dd)
goto ret; /* return 1 (failure) */
}
if (pkg_name)
{
dd_save_text(dd, FILENAME_PACKAGE, pkg_name->p_nvr);
dd_save_text(dd, FILENAME_PKG_EPOCH, pkg_name->p_epoch);
dd_save_text(dd, FILENAME_PKG_NAME, pkg_name->p_name);
dd_save_text(dd, FILENAME_PKG_VERSION, pkg_name->p_version);
dd_save_text(dd, FILENAME_PKG_RELEASE, pkg_name->p_release);
dd_save_text(dd, FILENAME_PKG_ARCH, pkg_name->p_arch);
}
if (component)
{
dd_save_text(dd, FILENAME_COMPONENT, component);
}
dd_close(dd);
ret0:
error = 0;
ret:
free(cmdline);
free(executable);
free(rootdir);
free(script_name);
free(package_short_name);
free_pkg_envra(pkg_name);
free(component);
return error;
}
int main(int argc, char **argv)
{
/* I18n */
setlocale(LC_ALL, "");
#if ENABLE_NLS
bindtextdomain(PACKAGE, LOCALEDIR);
textdomain(PACKAGE);
#endif
abrt_init(argv);
const char *dump_dir_name = ".";
const char *conf_filename = CONF_DIR"/abrt-action-save-package-data.conf";
/* Can't keep these strings/structs static: _() doesn't support that */
const char *program_usage_string = _(
"& [-v] [-c CONFFILE] -d DIR\n"
"\n"
"Query package database and save package and component name"
);
enum {
OPT_v = 1 << 0,
OPT_d = 1 << 1,
OPT_c = 1 << 2,
};
/* Keep enum above and order of options below in sync! */
struct options program_options[] = {
OPT__VERBOSE(&g_verbose),
OPT_STRING('d', NULL, &dump_dir_name, "DIR" , _("Dump directory")),
OPT_STRING('c', NULL, &conf_filename, "CONFFILE", _("Configuration file")),
OPT_END()
};
/*unsigned opts =*/ parse_opts(argc, argv, program_options, program_usage_string);
export_abrt_envvars(0);
VERB1 log("Loading settings");
if (load_conf(conf_filename) != 0)
return 1; /* syntax error (logged already by load_conf) */
VERB1 log("Initializing rpm library");
rpm_init();
GList *li;
for (li = settings_setOpenGPGPublicKeys; li != NULL; li = g_list_next(li))
{
VERB1 log("Loading GPG key '%s'", (char*)li->data);
rpm_load_gpgkey((char*)li->data);
}
return SavePackageDescriptionToDebugDump(dump_dir_name);
/* can call rpm_destroy but do we really need to bother? we are exiting! */
}