Introduce tool abrt-dump-journal-xorg #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo in commit message: 'xorg: introduce library xort-utils' |
| rlRun "ABRT_DUMP_JOURNAL_XORG_DEBUG_FILTER=\"SYSLOG_IDENTIFIER=${SYSLOG_IDENTIFIER}\" setsid ${exe} ${args} -vvv -f -xD -o >${crash_name}.log 2>&1 &" | ||
| rlRun "ABRT_DUMPER_PID=$!" | ||
| cp ${crash_name}.log /tmp/test.log | ||
|
|
|
Otherwise fine. Good job |
mhabrnal
force-pushed
the
dump_journal_xorg_final
branch
from
ec1c88f
to
c4f68a1
Compare
|
I've addressed all @sorki 's comments. |
mhabrnal
force-pushed
the
dump_journal_xorg_final
branch
2 times, most recently
from
a37c6ea
to
e385cbd
Compare
mhabrnal
force-pushed
the
dump_journal_xorg_final
branch
12 times, most recently
from
dfb2f55
to
63a5685
Compare
added 10 commits
November 6, 2015 11:57
Mostly copying from abrt-dump-xorg. The library was created becase the new tool for dump xorg crashes from journal will be introduced. Resolves #1023 Related to rhbz#1246373 Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
skip_pfx() expecting string which starts with '[' but Xorg journal messages do not start with '[' but with '(EE)'. Resolves #1023 Related to rhbz#1246373 Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
Add option to define CFLAGS and FDFLAGS for compiler for each test case separately by AT_TESTCFUN(NAME, CFLAGS, LDFLAGS, SOURCE) macro. Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
Resolves #1023 Related to rhbz#1246373 Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
Resolves #1023 Related to rhbz#1246373 Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
The function reads and returns next line from journal, if exists. Resolves #1023 Related to rhbz#1246373 Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
Resolves #1023 Related to rhbz#1246373 Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
The tool follows journal and dump Xorg crashes, if occur. Resolves #1023 Related to rhbz#1246373 Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
…_filter() In case we want to use more journal filter it is easier to manipulate with GList than with array. Also argument parser returns GList in case of LIST parameter. Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
added 2 commits
November 6, 2015 11:57
xorg.conf is no longer located in /etc/abrt/xorg.conf but in /etc/abrt/plugins/xorg.conf. Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
Journal filter can be be specified either by parameter -j or in xorg.conf conf file (option JournalFilters). Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
mhabrnal
force-pushed
the
dump_journal_xorg_final
branch
3 times, most recently
from
40941df
to
1200b0d
Compare
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
mhabrnal
force-pushed
the
dump_journal_xorg_final
branch
from
1200b0d
to
84c6fb5
Compare
jfilak
added a commit
that referenced
this pull request
Nov 6, 2015
Introduce tool abrt-dump-journal-xorg
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1023
Related to rhbz#1246373