Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GSettings to check whether to send uReports #903

Closed
wants to merge 3 commits into from

Conversation

jfilak
Copy link
Contributor

@jfilak jfilak commented Jan 20, 2015

No description provided.

hadess and others added 3 commits January 20, 2015 08:50
Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Jakub Filak <jfilak@redhat.com>
@hadess
Copy link
Contributor

hadess commented Jan 20, 2015

That seems counter-productive to me. That would mean that sysadmins need to change 2 settings if they want to force having uReports sent, instead of one, depending on the desktop to be used.

@mcatanzaro
Copy link

It might make for sense for gnome-control-center to just parse the existing configuration file, if you don't want to switch fully to gsettings.

@mcatanzaro
Copy link

I mean, it'd be NICE to have this as a gsetting, since that's where all our other settings are, but having the same setting in two places seems worse to me than the status quo.

@jfilak
Copy link
Contributor Author

jfilak commented Jan 21, 2015

Since I am not able to determine whether the gsetting has been set, I had to use this approach. I would rather use the gsetting only, but I want to display the dialogue in non-GNOME desktops and update the gsetting from the applet as the other desktops don't have their privacy panels yet.

@hadess
Copy link
Contributor

hadess commented Jan 21, 2015

Why do you need to register whether the GSettings had been set? We want to remove the nag dialogue in GNOME. I'm this close -><- to ending the argument by forking the applet. There's no reason to be spending this much time to engineering 1000 lines of code.

@jfilak
Copy link
Contributor Author

jfilak commented Jan 21, 2015

@hadess OK, the dialogue will not be removed in GNOME.

@jfilak jfilak closed this Jan 21, 2015
@jfilak jfilak deleted the applet_gsettings branch May 4, 2015 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants