Get problem data over dbus #938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 24, 2015 19:02
This commit fixes the crap I introduced in commit 57895cc Signed-off-by: Jakub Filak <jfilak@redhat.com>
This function is required because users may not have direct file system access to the problem data. Signed-off-by: Jakub Filak <jfilak@redhat.com>
It is sometimes necessary to check if some elemen exist, so this method should be fast as much as it is possible to do this task over DBus. I was thinking about calling the GetInfo method with a single element but I refused this idea as it is inherently overcomplicated and error prone. Signed-off-by: Jakub Filak <jfilak@redhat.com>
To conveniently use the DBus methods. Signed-off-by: Jakub Filak <jfilak@redhat.com>
The dump directory is no longer accessible by non-root users and we also want to get rid of direct access to allow administrators (wheel members) see problem data without the need to ChownProblem directory before. Signed-off-by: Jakub Filak <jfilak@redhat.com>
|
looks good for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this pull request, abrt-cli works only for root user. The changes are tested by already existing test cases. Please, review this pull request ASAP.
Requires: abrt/libreport#341
Resolves: rhbz#1205439