Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of errors caused by parsing /etc/system-release #147

Closed
jfilak opened this issue Mar 27, 2013 · 4 comments
Closed

get rid of errors caused by parsing /etc/system-release #147

jfilak opened this issue Mar 27, 2013 · 4 comments
Assignees
@jfilak

Comments

@jfilak
Copy link
Contributor

jfilak commented Mar 27, 2013

Use machine readable /etc/os-release instead. See 'man os-release'

OpenSUSE use it too: http://0pointer.de/blog/projects/os-release

What this change could fix?
Server responded with an error: 'Validation failed: error validating 'os': error validating 'name': string "RFRemix release 18 (Spherical Cow)" is too long (maximum 32)'
@jfilak jfilak mentioned this issue Mar 29, 2013
Open
@mozeq
Copy link
Contributor

mozeq commented Apr 9, 2013

  • /etc/os-release is not in rhel6, so please keep that in mind when implementing this

@jfilak
Copy link
Contributor Author

jfilak commented Apr 9, 2013

Thank you Jiri! A new implementation should use the current one as fallback.

Usefull links:
http://www.freedesktop.org/software/systemd/man/os-release.html

@ohhai
Copy link

ohhai commented Apr 13, 2013

Got subject issue in Fedora 18 x64, seems like it blocks auto submission process for a crash report.

@ghost ghost assigned jfilak Apr 15, 2013
jfilak pushed a commit that referenced this issue Apr 18, 2013
refactorize: map_string_t clean up
2e66c76 
libreport hides GHashTable behind map_string_t and adds some utility
functions using map_string_t type. Programmer should use map_string_t
instead of GHashTable but libreport calls some GHashTable functions
directly. This patch adds wrappers for GHashTable functions and makes
libreport using them.

Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Apr 18, 2013
dd: add /etc/os-release to basic files
52832af 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Apr 18, 2013
add function for parsing os-release
a61d182 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Apr 18, 2013
unit tests: add test for osinfo parsers
4d0f32c 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Apr 18, 2013
problem data: add function getting parsed osinfo
8f46426 
The function loads os_info from chrooted directory if problem data
contains chrootdir item, otherwise loads the standard os_info.

If os_info item is not pressent, the function adds PRETTY_NAME
key with content of os_release item to the result map.

Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Apr 18, 2013
unit tests: add test for problem data get osinfo
e37e83a 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Apr 18, 2013
plugins: support /etc/os-release
b11d6a7 
Related to #147 (os-release)

Signed-off-by: Jakub Filak <jfilak@redhat.com>
jfilak pushed a commit that referenced this issue Apr 23, 2013
@mmilata
refactorize: map_string_t clean up
68377ab 
libreport hides GHashTable behind map_string_t and adds some utility
functions using map_string_t type. Programmer should use map_string_t
instead of GHashTable but libreport calls some GHashTable functions
directly. This patch adds wrappers for GHashTable functions and makes
libreport using them.

Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit that referenced this issue Apr 23, 2013
@mmilata
dd: add /etc/os-release to basic files
dcbf724 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit that referenced this issue Apr 23, 2013
@mmilata
add function for parsing os-release
a38367c 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit that referenced this issue Apr 23, 2013
@mmilata
unit tests: add test for osinfo parsers
cc303ff 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit that referenced this issue Apr 23, 2013
@mmilata
problem data: add function getting parsed osinfo
d53838e 
The function loads os_info from chrooted directory if problem data
contains chrootdir item, otherwise loads the standard os_info.

If os_info item is not pressent, the function adds PRETTY_NAME
key with content of os_release item to the result map.

Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit that referenced this issue Apr 23, 2013
@mmilata
unit tests: add test for problem data get osinfo
46ccf77 
Related to #147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit that referenced this issue Apr 23, 2013
@mmilata
plugins: support /etc/os-release
d09b68b 
Related to #147 (os-release)

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit to abrt/abrt that referenced this issue Apr 23, 2013
@mmilata
refactorize: reflect recent changes in map_string_t
4012dd0 
Related to abrt/libreport#147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
jfilak pushed a commit to abrt/abrt that referenced this issue Apr 23, 2013
@mmilata
bodhi, retrace: support /etc/os-release
3bc9a62 
Related to abrt/libreport#147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>
@jfilak
Copy link
Contributor Author

jfilak commented Oct 30, 2013

libreport uses /etc/os-release if available

@jfilak jfilak closed this as completed Oct 30, 2013
jfilak pushed a commit to abrt/abrt that referenced this issue May 14, 2014
refactorize: reflect recent changes in map_string_t
4d753e8 
Related to abrt/libreport#147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>

Conflicts:

	src/daemon/abrt-action-save-package-data.c
	src/lib/abrt_conf.c
	src/plugins/abrt-action-analyze-xorg.c
jfilak pushed a commit to abrt/abrt that referenced this issue Feb 19, 2015
refactorize: reflect recent changes in map_string_t
5f1130b 
Related to abrt/libreport#147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>

Conflicts:

	src/daemon/abrt-action-save-package-data.c
	src/lib/abrt_conf.c
	src/plugins/abrt-action-analyze-xorg.c
jfilak pushed a commit to abrt/abrt that referenced this issue Feb 25, 2015
refactorize: reflect recent changes in map_string_t
e0de575 
Related to abrt/libreport#147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>

Conflicts:

	src/daemon/abrt-action-save-package-data.c
	src/lib/abrt_conf.c
	src/plugins/abrt-action-analyze-xorg.c
jfilak pushed a commit to abrt/abrt that referenced this issue Feb 26, 2015
refactorize: reflect recent changes in map_string_t
732c150 
Related to abrt/libreport#147

Signed-off-by: Jakub Filak <jfilak@redhat.com>
Signed-off-by: Martin Milata <mmilata@redhat.com>

Conflicts:

	src/daemon/abrt-action-save-package-data.c
	src/lib/abrt_conf.c
	src/plugins/abrt-action-analyze-xorg.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jfilak jfilak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mozeq @jfilak @ohhai