Allow, destructuring hashes, closes #47 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
myhash = {"some": "thing", "over": "the rainbow", "x": "y"}
some, over = myhash
echo(some) # "thing"
```
@ntwrick I had to revert one of your changes we introduced
when adding error lines etc. When we evaluate null literals
we always return a new object, and this means that when
you compare `null == null` that is `false` as they're 2
different objects. For now I reverted that line you changed
but maybe we could also think of adding a special case to
handle `==` with nulls. Problem is, you'd have to add another
special case for `!=` so I think it's probably easier to just
reuse the same object for nulls...what do you think?
|
@ntwrick if you think it might be worth it I can probably backport the fix for null comparisons to 1.0.2, wdyt? |
Closed
ntwrick
approved these changes
Feb 1, 2019
|
No worries at all! I'll tag you as a reviewer when I'd like your input here
and there, so no worries -- not a full time job and feel free to ignore
when you don't have the time!
…On Fri, 1 Feb, 2019, 6:50 PM Erich (Rick) Arnold ***@***.*** wrote:
***@***.**** approved this pull request.
I see the *ast.NullLiteral case change. Looks good.
BTW, I can review as time permits, but being retired I'm not always
immediately available. I don't want to get on your critical path and hold
you up. So please proceed as you see fit.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#151 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAUC5HM8VAVIDbKjbJWV6ScDtllYkrGHks5vJFQkgaJpZM4adSP4>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ntwrick I had to revert one of your changes we introduced
when adding error lines etc. When we evaluate null literals
we always return a new object, and this means that when
you compare
null == nullthat isfalseas they're 2different objects. For now I reverted that line you changed
but maybe we could also think of adding a special case to
handle
==with nulls. Problem is, you'd have to add anotherspecial case for
!=so I think it's probably easier to justreuse the same object for nulls...what do you think?