Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: absolute path to framework using CMake config mode #1494

Closed
daschuer opened this issue Jul 26, 2023 · 0 comments
Closed

[Bug]: absolute path to framework using CMake config mode #1494

daschuer opened this issue Jul 26, 2023 · 0 comments

Comments

@daschuer
Copy link
Contributor

Describe the issue

This way compilation will fail after updating to a new XCode version.

This is also an issue when building on a different machine than the final target.

See microsoft/vcpkg#16259

set_target_properties(absl::time_zone PROPERTIES
  INTERFACE_INCLUDE_DIRECTORIES "${_IMPORT_PREFIX}/include"
  INTERFACE_LINK_LIBRARIES "\$<\$<PLATFORM_ID:Darwin>:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreFoundation.framework>"
)

Steps to reproduce the problem

Build Abseil and look into abslTargets.cmake

What version of Abseil are you using?

20230125.0

What operating system and version are you using?

macOS

What compiler and version are you using?

?

What build system are you using?

cmake version 3.26.4

Additional context

No response
daschuer added a commit to daschuer/abseil-cpp that referenced this issue Jul 26, 2023
@daschuer
CMake: Link CoreFoundation with -framework
f3ff6bc 
This fixes abseil#1494
@daschuer daschuer mentioned this issue Jul 26, 2023
Closed
razmser pushed a commit to razmser/abseil-cpp that referenced this issue Aug 31, 2023
@daschuer @razmser
PR abseil#1495: CMake: Link CoreFoundation with -framework
3c07eb6 
Imported from GitHub PR abseil#1495

This fixes abseil#1494

With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>`
but abseil is still at CMake 3.10

The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925

Merge f3ff6bc into c9c0fd5

Merging this change closes abseil#1495

COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc
PiperOrigin-RevId: 552564485
Change-Id: I57b580e5795c54865576110e56220128d8b603b8
razmser pushed a commit to razmser/abseil-cpp that referenced this issue Sep 12, 2023
@daschuer @razmser
PR abseil#1495: CMake: Link CoreFoundation with -framework
d37160d 
Imported from GitHub PR abseil#1495

This fixes abseil#1494

With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>`
but abseil is still at CMake 3.10

The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925

Merge f3ff6bc into c9c0fd5

Merging this change closes abseil#1495

COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc
PiperOrigin-RevId: 552564485
Change-Id: I57b580e5795c54865576110e56220128d8b603b8
razmser pushed a commit to razmser/abseil-cpp that referenced this issue Sep 12, 2023
@daschuer @razmser
PR abseil#1495: CMake: Link CoreFoundation with -framework
9f85abb 
Imported from GitHub PR abseil#1495

This fixes abseil#1494

With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>`
but abseil is still at CMake 3.10

The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925

Merge f3ff6bc into c9c0fd5

Merging this change closes abseil#1495

COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc
PiperOrigin-RevId: 552564485
Change-Id: I57b580e5795c54865576110e56220128d8b603b8
razmser pushed a commit to razmser/abseil-cpp that referenced this issue Sep 14, 2023
@daschuer @razmser
PR abseil#1495: CMake: Link CoreFoundation with -framework
5755db2 
Imported from GitHub PR abseil#1495

This fixes abseil#1494

With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>`
but abseil is still at CMake 3.10

The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925

Merge f3ff6bc into c9c0fd5

Merging this change closes abseil#1495

COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc
PiperOrigin-RevId: 552564485
Change-Id: I57b580e5795c54865576110e56220128d8b603b8
netkex pushed a commit to netkex/abseil-cpp that referenced this issue Apr 3, 2024
@daschuer @netkex
PR abseil#1495: CMake: Link CoreFoundation with -framework
2b7648f 
Imported from GitHub PR abseil#1495

This fixes abseil#1494

With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>`
but abseil is still at CMake 3.10

The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925

Merge f3ff6bc into c9c0fd5

Merging this change closes abseil#1495

COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc
PiperOrigin-RevId: 552564485
Change-Id: I57b580e5795c54865576110e56220128d8b603b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CMake: Link CoreFoundation with -framework daschuer/abseil-cpp
1 participant
@daschuer