CMake: Link CoreFoundation with -framework #1495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
razmser
pushed a commit
to razmser/abseil-cpp
that referenced
this pull request
Aug 31, 2023
Imported from GitHub PR abseil#1495 This fixes abseil#1494 With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>` but abseil is still at CMake 3.10 The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925 Merge f3ff6bc into c9c0fd5 Merging this change closes abseil#1495 COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc PiperOrigin-RevId: 552564485 Change-Id: I57b580e5795c54865576110e56220128d8b603b8
razmser
pushed a commit
to razmser/abseil-cpp
that referenced
this pull request
Sep 12, 2023
Imported from GitHub PR abseil#1495 This fixes abseil#1494 With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>` but abseil is still at CMake 3.10 The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925 Merge f3ff6bc into c9c0fd5 Merging this change closes abseil#1495 COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc PiperOrigin-RevId: 552564485 Change-Id: I57b580e5795c54865576110e56220128d8b603b8
razmser
pushed a commit
to razmser/abseil-cpp
that referenced
this pull request
Sep 12, 2023
Imported from GitHub PR abseil#1495 This fixes abseil#1494 With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>` but abseil is still at CMake 3.10 The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925 Merge f3ff6bc into c9c0fd5 Merging this change closes abseil#1495 COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc PiperOrigin-RevId: 552564485 Change-Id: I57b580e5795c54865576110e56220128d8b603b8
razmser
pushed a commit
to razmser/abseil-cpp
that referenced
this pull request
Sep 14, 2023
Imported from GitHub PR abseil#1495 This fixes abseil#1494 With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>` but abseil is still at CMake 3.10 The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925 Merge f3ff6bc into c9c0fd5 Merging this change closes abseil#1495 COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc PiperOrigin-RevId: 552564485 Change-Id: I57b580e5795c54865576110e56220128d8b603b8
netkex
pushed a commit
to netkex/abseil-cpp
that referenced
this pull request
Apr 3, 2024
Imported from GitHub PR abseil#1495 This fixes abseil#1494 With CMake 3.24 we can also use `$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>` but abseil is still at CMake 3.10 The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925 Merge f3ff6bc into c9c0fd5 Merging this change closes abseil#1495 COPYBARA_INTEGRATE_REVIEW=abseil#1495 from daschuer:framework-link-fix f3ff6bc PiperOrigin-RevId: 552564485 Change-Id: I57b580e5795c54865576110e56220128d8b603b8
copybara-service bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
Imported from GitHub PR #1695 #1495 converted the `if (APPLE)` check for linking against `CoreFoundation` to generator expressions, which is fine and all. The issue is that they forgot the other Apple platforms, making builds for iOS impossible. This patch fixes this issue by adding the other Apple platforms that CMake support to the generator expression. Merge 4f01df8 into 6dee153 Merging this change closes #1695 COPYBARA_INTEGRATE_REVIEW=#1695 from GeniusVentures:fix-time-build 4f01df8 PiperOrigin-RevId: 651416278 Change-Id: I47e4d52384e946cc9e421922f7c6edd5bfa1d976
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1494
With CMake 3.24 we can also use
$<LINK_LIBRARY:FRAMEWORK,CoreFoundation>but abseil is still at CMake 3.10
The change has been tested here: https://github.com/daschuer/vcpkg/actions/runs/5670741925