Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#187 Add Conan recipe #231

Merged
merged 5 commits into from
Dec 20, 2018
Merged

#187 Add Conan recipe #231

merged 5 commits into from
Dec 20, 2018

Conversation

uilianries
Copy link
Contributor

Hi!

This PR is related to #187 which provides Conan package support for Google Abseil.

The recipe included on this PR contains some metadata, as author, project url, license, and steps needed to create the package.
As cctz it's listed as requirement for Abseil and will be downloaded automatically when building Abseil using Conan.

How to build Abseil using Conan?

$ conan create . abseil/latest@abseil/stable

Conan create will execute all steps, including download cctz and create a binary package for Abseil.

The PR #197 is related to CI support, which is awesome, because we could include Conan on CI build steps to distribute Abseil as pre-built binaries. Of course, this should be done in a next PR.

Regards!

closes #187

I'm adding some Conan experts to review this PR:
/cc @danimtb @memsharded

- Add generic Conan recipe

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@rongjiecomputer
Copy link
Contributor

As cctz it's listed as requirement for Abseil and will be downloaded automatically when building Abseil using Conan.

Abseil no longer require downloading CCTZ. CCTZ is already part of Abseil under absl/time/internal.

@uilianries
Copy link
Contributor Author

Great! I'm going to remove it, thanks for reviewing

- CCTZ was embedded in absl/time/internal

Signed-off-by: Uilian Ries <uilianries@gmail.com>
@uilianries
Copy link
Contributor Author

Done, CCTZ removed.

Copy link

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Having support for Conan in this library will be great! Thanks @uilianries

Copy link

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add topics, LGTM otherwise

@uilianries
Copy link
Contributor Author

well observed, I'm gonna update this.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
conanfile.py Outdated Show resolved Hide resolved
conanfile.py Outdated Show resolved Hide resolved
conanfile.py Show resolved Hide resolved
conanfile.py Show resolved Hide resolved
@ahedberg
Copy link
Contributor

This will be merged by @mbxx later today as part of our daily release process.

@uilianries
Copy link
Contributor Author

Thank you!

@mbxx mbxx merged commit 3e2e9b5 into abseil:master Dec 20, 2018
zhangxy988 pushed a commit that referenced this pull request Dec 21, 2018
--
d99e8545a19cec7569c1f04404398e4d31e71e81 by Mark Barolak <mbar@google.com>:

Internal import of GitHub PR #231: "Add Conan recipe"
#231

PiperOrigin-RevId: 226376774
GitOrigin-RevId: d99e8545a19cec7569c1f04404398e4d31e71e81
Change-Id: I763db5e14b9d0250c0859b3c12a4b8f374362c15
absl-federation-github pushed a commit that referenced this pull request Aug 8, 2019
  - 9ee91d3 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8efba58 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b49b8d1 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 67222ff Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c5c4db4 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 14550be Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 52e88ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 36d37ab Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ad1485c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f3840bc Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 278b260 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c6c3c1b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 44efe96 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 3c98fcc Merge pull request #340 from jtsylve/macos_cxx17_fix by Matt Calabrese <38107210+mattcalabrese-google@users.noreply.github.com>
  - 74d9175 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e6b0502 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c964fcf Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 72e09a5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d65e19d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5162fc8 Merge pull request #336 from shields/patch-2 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com>
  - 0389f7b Merge pull request #335 from shields/patch-1 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com>
  - e9324d9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 43ef214 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a13d3df Merge pull request #323 from gosnik/master by Gennadiy Rozental <rogeeff@google.com>
  - 310a118 Merge pull request #324 from RasPat1/patch-1 by Gennadiy Rozental <rogeeff@google.com>
  - 8f11724 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - b1dd425 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 361cb8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0238ab0 Merge pull request #321 from christoph-cullmann/c4245_fix... by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 61c9bf3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bc9101f Merge pull request #320 from christoph-cullmann/master by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 2f76a9b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 4adaf54 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 27c30ec Avoid undefined behavior when nullptr is passed to memcpy... by Roman Gershman <romange@gmail.com>
  - ce65f5a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a18fc74 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8a394b1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - daf381e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - fa00c32 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 436ba6c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0cbdc77 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 27c2f6e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - aa468ad Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - cd86d0d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 33841c5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ca3f875 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d902eb8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a02f62f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0b545b4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - dbae876 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 044da8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6cc6ac4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 666fc12 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 93dfcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2c8421e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5b65c4a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - eab2078 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 253eb74 [CMake] Set correct flags for clang-cl (#278) by Loo Rong Jie <loorongjie@gmail.com>
  - e75672f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bf29470 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6fd8271 Merge pull request #280 from chiumichael/master by Derek Mauro <761129+derekmauro@users.noreply.github.com>
  - 7c7754f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 256be56 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 88a152a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c1cecb2 Implement Span::first and Span::last from C++20 (#274) by Girts <girtsf@users.noreply.github.com>
  - 38b7043 Changed HTTP URLs to HTTPS where possible (#270) by nik7273 <nik8470@gmail.com>
  - febc5ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9fdf5e5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 419f318 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - b312c3c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 308ce31 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 93d155b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 426eaa4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2901ec3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d78310f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a4cb1c8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 540e253 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 89ea0c5 Merge pull request #255 from uilianries/hotfix/conan by ahedberg <ahedberg@google.com>
  - 5e0dcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0dffca4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6b4201f Fix GCC8 warnings by Boris Staletic <boris.staletic@gmail.com>
  - 0b1e6d4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - efccc50 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5e6a781 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5eea0f7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 66f9bec Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 018b4db Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9449ae9 Merge pull request #243 from ThomsonTan/FixIntrinsic by Alex Strelnikov <strel@google.com>
  - b16aeb6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7ffbe09 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 01b471d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7bd8f36 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 968a34f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 3e2e9b5 Merge pull request #231 from uilianries/feature/conan by Mark Barolak <mbxx@users.noreply.github.com>
  - 111ca70 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 389ec3f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8fbcdb9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 455dc17 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f197d7c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 284378a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>

GitOrigin-RevId: 9ee91d3
Change-Id: Ia06e548bc106cc9d136f6c65714be6645317aced
WangTingMan pushed a commit to WangTingMan/abseil-cpp that referenced this pull request Oct 25, 2023
  - 9ee91d3 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8efba58 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b49b8d1 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 67222ff Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c5c4db4 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 14550be Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 52e88ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 36d37ab Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ad1485c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f3840bc Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 278b260 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c6c3c1b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 44efe96 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 3c98fcc Merge pull request abseil#340 from jtsylve/macos_cxx17_fix by Matt Calabrese <38107210+mattcalabrese-google@users.noreply.github.com>
  - 74d9175 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e6b0502 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c964fcf Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 72e09a5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d65e19d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5162fc8 Merge pull request abseil#336 from shields/patch-2 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com>
  - 0389f7b Merge pull request abseil#335 from shields/patch-1 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com>
  - e9324d9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 43ef214 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a13d3df Merge pull request abseil#323 from gosnik/master by Gennadiy Rozental <rogeeff@google.com>
  - 310a118 Merge pull request abseil#324 from RasPat1/patch-1 by Gennadiy Rozental <rogeeff@google.com>
  - 8f11724 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - b1dd425 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 361cb8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0238ab0 Merge pull request abseil#321 from christoph-cullmann/c4245_fix... by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 61c9bf3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bc9101f Merge pull request abseil#320 from christoph-cullmann/master by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 2f76a9b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 4adaf54 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 27c30ec Avoid undefined behavior when nullptr is passed to memcpy... by Roman Gershman <romange@gmail.com>
  - ce65f5a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a18fc74 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8a394b1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - daf381e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - fa00c32 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 436ba6c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0cbdc77 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 27c2f6e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - aa468ad Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - cd86d0d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 33841c5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ca3f875 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d902eb8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a02f62f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0b545b4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - dbae876 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 044da8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6cc6ac4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 666fc12 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 93dfcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2c8421e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5b65c4a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - eab2078 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 253eb74 [CMake] Set correct flags for clang-cl (abseil#278) by Loo Rong Jie <loorongjie@gmail.com>
  - e75672f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bf29470 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6fd8271 Merge pull request abseil#280 from chiumichael/master by Derek Mauro <761129+derekmauro@users.noreply.github.com>
  - 7c7754f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 256be56 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 88a152a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c1cecb2 Implement Span::first and Span::last from C++20 (abseil#274) by Girts <girtsf@users.noreply.github.com>
  - 38b7043 Changed HTTP URLs to HTTPS where possible (abseil#270) by nik7273 <nik8470@gmail.com>
  - febc5ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9fdf5e5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 419f318 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - b312c3c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 308ce31 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 93d155b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 426eaa4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2901ec3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d78310f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a4cb1c8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 540e253 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 89ea0c5 Merge pull request abseil#255 from uilianries/hotfix/conan by ahedberg <ahedberg@google.com>
  - 5e0dcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0dffca4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6b4201f Fix GCC8 warnings by Boris Staletic <boris.staletic@gmail.com>
  - 0b1e6d4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - efccc50 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5e6a781 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5eea0f7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 66f9bec Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 018b4db Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9449ae9 Merge pull request abseil#243 from ThomsonTan/FixIntrinsic by Alex Strelnikov <strel@google.com>
  - b16aeb6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7ffbe09 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 01b471d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7bd8f36 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 968a34f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 3e2e9b5 Merge pull request abseil#231 from uilianries/feature/conan by Mark Barolak <mbxx@users.noreply.github.com>
  - 111ca70 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 389ec3f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8fbcdb9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 455dc17 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f197d7c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 284378a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>

GitOrigin-RevId: 9ee91d3
Change-Id: Ia06e548bc106cc9d136f6c65714be6645317aced
4s5t2os41n added a commit to 4s5t2os41n/abseil-cpp that referenced this pull request Jul 4, 2024
--
d99e8545a19cec7569c1f04404398e4d31e71e81 by Mark Barolak <mbar@google.com>:

Internal import of GitHub PR #231: "Add Conan recipe"
abseil/abseil-cpp#231

PiperOrigin-RevId: 226376774
GitOrigin-RevId: d99e8545a19cec7569c1f04404398e4d31e71e81
Change-Id: I763db5e14b9d0250c0859b3c12a4b8f374362c15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conan Package Support
8 participants