_umul128 intrinsic is x64 only and not available on Windows ARM64 #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ThomsonTan, thanks for the fix and sorry for the delayed response. Just a question before merging, are you able to give any context / verification on this documentation for _umul128? It seems to imply _umul128 availability on ARM. |
|
@astrelni this issue happens when building Chromium for Windows ARM64 which also defines BTW: when could this change reach Chromium master? |
|
Hi @astrelni , confirmed that it is a document error for intrinsic |
astrelni
approved these changes
Jan 8, 2019
|
@ThomsonTan |
|
Thanks @astrelni . Do I need look into the failure of Linux CI-gcc-opt build? I don't know how could my change affect that. |
|
@ThomsonTan I think it's part of an issue kokoro itself is having right now, I don't think there's anything for you to do about it. I will hopefully get this merged early tomorrow. |
absl-federation-github
pushed a commit
that referenced
this pull request
Jan 9, 2019
-- fd86c60bac6c41f1629ce1ab7dc1c8edff398a59 by Alex Strelnikov <strel@google.com>: Import PR: #243 Fix Windows ARM64 intrinsic use. PiperOrigin-RevId: 228535649 -- a0ca663f606a3b31493683e405be2b1cff450894 by CJ Johnson <johnsoncj@google.com>: Fixes issue of mixed signedness comparison PiperOrigin-RevId: 228535623 -- d71aaa1705d7303b43fe02088fe07b153e647796 by Shaindel Schwartz <shaindel@google.com>: Import of CCTZ from GitHub. PiperOrigin-RevId: 228534365 -- c1b49d361aa880198e071f93997724bddbcd4760 by Samuel Benzaquen <sbenza@google.com>: Internal cleanup PiperOrigin-RevId: 228406627 -- 0c4b1c2bed107698e209055b3431771d7a1bdba1 by Dave Walker <dawalker@google.com>: Add comments about the purpose of container_internal::slot_type. PiperOrigin-RevId: 228264537 -- 060aa6077d2f3a0a129149e0644d19f2f521b241 by Abseil Team <absl-team@google.com>: #include <cmath> in hashtablez_sampler.cc Expected to fix the android build. PiperOrigin-RevId: 228222550 GitOrigin-RevId: fd86c60bac6c41f1629ce1ab7dc1c8edff398a59 Change-Id: I26339fd4548c1a81b037cb52c26910d1bd850ea8
absl-federation-github
pushed a commit
that referenced
this pull request
Aug 8, 2019
- 9ee91d3 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8efba58 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b49b8d1 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 67222ff Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c5c4db4 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 14550be Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 52e88ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 36d37ab Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - ad1485c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - f3840bc Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 278b260 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - c6c3c1b Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 44efe96 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 3c98fcc Merge pull request #340 from jtsylve/macos_cxx17_fix by Matt Calabrese <38107210+mattcalabrese-google@users.noreply.github.com> - 74d9175 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - e6b0502 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - c964fcf Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 72e09a5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - d65e19d Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5162fc8 Merge pull request #336 from shields/patch-2 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com> - 0389f7b Merge pull request #335 from shields/patch-1 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com> - e9324d9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 43ef214 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a13d3df Merge pull request #323 from gosnik/master by Gennadiy Rozental <rogeeff@google.com> - 310a118 Merge pull request #324 from RasPat1/patch-1 by Gennadiy Rozental <rogeeff@google.com> - 8f11724 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - b1dd425 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 361cb8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0238ab0 Merge pull request #321 from christoph-cullmann/c4245_fix... by Xiaoyi Zhang <zhangxy988@gmail.com> - 61c9bf3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - bc9101f Merge pull request #320 from christoph-cullmann/master by Xiaoyi Zhang <zhangxy988@gmail.com> - 2f76a9b Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 4adaf54 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 27c30ec Avoid undefined behavior when nullptr is passed to memcpy... by Roman Gershman <romange@gmail.com> - ce65f5a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a18fc74 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 8a394b1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - daf381e Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - fa00c32 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 436ba6c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0cbdc77 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 27c2f6e Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - aa468ad Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - cd86d0d Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 33841c5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - ca3f875 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - d902eb8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a02f62f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0b545b4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - dbae876 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 044da8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 6cc6ac4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 666fc12 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 93dfcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 2c8421e Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5b65c4a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - eab2078 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 253eb74 [CMake] Set correct flags for clang-cl (#278) by Loo Rong Jie <loorongjie@gmail.com> - e75672f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - bf29470 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 6fd8271 Merge pull request #280 from chiumichael/master by Derek Mauro <761129+derekmauro@users.noreply.github.com> - 7c7754f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 256be56 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 88a152a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - c1cecb2 Implement Span::first and Span::last from C++20 (#274) by Girts <girtsf@users.noreply.github.com> - 38b7043 Changed HTTP URLs to HTTPS where possible (#270) by nik7273 <nik8470@gmail.com> - febc5ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 9fdf5e5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 419f318 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - b312c3c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 308ce31 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 93d155b Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 426eaa4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 2901ec3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - d78310f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a4cb1c8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 540e253 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 89ea0c5 Merge pull request #255 from uilianries/hotfix/conan by ahedberg <ahedberg@google.com> - 5e0dcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0dffca4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 6b4201f Fix GCC8 warnings by Boris Staletic <boris.staletic@gmail.com> - 0b1e6d4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - efccc50 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5e6a781 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5eea0f7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 66f9bec Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 018b4db Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 9449ae9 Merge pull request #243 from ThomsonTan/FixIntrinsic by Alex Strelnikov <strel@google.com> - b16aeb6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 7ffbe09 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 01b471d Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 7bd8f36 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 968a34f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 3e2e9b5 Merge pull request #231 from uilianries/feature/conan by Mark Barolak <mbxx@users.noreply.github.com> - 111ca70 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 389ec3f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 8fbcdb9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 455dc17 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - f197d7c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 284378a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> GitOrigin-RevId: 9ee91d3 Change-Id: Ia06e548bc106cc9d136f6c65714be6645317aced
WangTingMan
pushed a commit
to WangTingMan/abseil-cpp
that referenced
this pull request
Oct 25, 2023
- 9ee91d3 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8efba58 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b49b8d1 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 67222ff Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c5c4db4 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 14550be Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 52e88ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 36d37ab Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - ad1485c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - f3840bc Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 278b260 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - c6c3c1b Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 44efe96 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 3c98fcc Merge pull request abseil#340 from jtsylve/macos_cxx17_fix by Matt Calabrese <38107210+mattcalabrese-google@users.noreply.github.com> - 74d9175 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - e6b0502 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - c964fcf Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 72e09a5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - d65e19d Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5162fc8 Merge pull request abseil#336 from shields/patch-2 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com> - 0389f7b Merge pull request abseil#335 from shields/patch-1 by Shaindel Schwartz <31392632+shaindelschwartz@users.noreply.github.com> - e9324d9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 43ef214 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a13d3df Merge pull request abseil#323 from gosnik/master by Gennadiy Rozental <rogeeff@google.com> - 310a118 Merge pull request abseil#324 from RasPat1/patch-1 by Gennadiy Rozental <rogeeff@google.com> - 8f11724 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - b1dd425 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 361cb8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0238ab0 Merge pull request abseil#321 from christoph-cullmann/c4245_fix... by Xiaoyi Zhang <zhangxy988@gmail.com> - 61c9bf3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - bc9101f Merge pull request abseil#320 from christoph-cullmann/master by Xiaoyi Zhang <zhangxy988@gmail.com> - 2f76a9b Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 4adaf54 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 27c30ec Avoid undefined behavior when nullptr is passed to memcpy... by Roman Gershman <romange@gmail.com> - ce65f5a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a18fc74 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 8a394b1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - daf381e Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - fa00c32 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 436ba6c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0cbdc77 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 27c2f6e Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - aa468ad Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - cd86d0d Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 33841c5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - ca3f875 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - d902eb8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a02f62f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0b545b4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - dbae876 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 044da8a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 6cc6ac4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 666fc12 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 93dfcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 2c8421e Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5b65c4a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - eab2078 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 253eb74 [CMake] Set correct flags for clang-cl (abseil#278) by Loo Rong Jie <loorongjie@gmail.com> - e75672f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - bf29470 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 6fd8271 Merge pull request abseil#280 from chiumichael/master by Derek Mauro <761129+derekmauro@users.noreply.github.com> - 7c7754f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 256be56 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 88a152a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - c1cecb2 Implement Span::first and Span::last from C++20 (abseil#274) by Girts <girtsf@users.noreply.github.com> - 38b7043 Changed HTTP URLs to HTTPS where possible (abseil#270) by nik7273 <nik8470@gmail.com> - febc5ee Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 9fdf5e5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 419f318 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - b312c3c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 308ce31 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 93d155b Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 426eaa4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 2901ec3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - d78310f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - a4cb1c8 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 540e253 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 89ea0c5 Merge pull request abseil#255 from uilianries/hotfix/conan by ahedberg <ahedberg@google.com> - 5e0dcf7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 0dffca4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 6b4201f Fix GCC8 warnings by Boris Staletic <boris.staletic@gmail.com> - 0b1e6d4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - efccc50 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5e6a781 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 5eea0f7 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 66f9bec Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 018b4db Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 9449ae9 Merge pull request abseil#243 from ThomsonTan/FixIntrinsic by Alex Strelnikov <strel@google.com> - b16aeb6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 7ffbe09 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 01b471d Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 7bd8f36 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 968a34f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 3e2e9b5 Merge pull request abseil#231 from uilianries/feature/conan by Mark Barolak <mbxx@users.noreply.github.com> - 111ca70 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 389ec3f Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 8fbcdb9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 455dc17 Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - f197d7c Export of internal Abseil changes. by Abseil Team <absl-team@google.com> - 284378a Export of internal Abseil changes. by Abseil Team <absl-team@google.com> GitOrigin-RevId: 9ee91d3 Change-Id: Ia06e548bc106cc9d136f6c65714be6645317aced
4s5t2os41n
added a commit
to 4s5t2os41n/abseil-cpp
that referenced
this pull request
Jul 4, 2024
-- fd86c60bac6c41f1629ce1ab7dc1c8edff398a59 by Alex Strelnikov <strel@google.com>: Import PR: abseil/abseil-cpp#243 Fix Windows ARM64 intrinsic use. PiperOrigin-RevId: 228535649 -- a0ca663f606a3b31493683e405be2b1cff450894 by CJ Johnson <johnsoncj@google.com>: Fixes issue of mixed signedness comparison PiperOrigin-RevId: 228535623 -- d71aaa1705d7303b43fe02088fe07b153e647796 by Shaindel Schwartz <shaindel@google.com>: Import of CCTZ from GitHub. PiperOrigin-RevId: 228534365 -- c1b49d361aa880198e071f93997724bddbcd4760 by Samuel Benzaquen <sbenza@google.com>: Internal cleanup PiperOrigin-RevId: 228406627 -- 0c4b1c2bed107698e209055b3431771d7a1bdba1 by Dave Walker <dawalker@google.com>: Add comments about the purpose of container_internal::slot_type. PiperOrigin-RevId: 228264537 -- 060aa6077d2f3a0a129149e0644d19f2f521b241 by Abseil Team <absl-team@google.com>: #include <cmath> in hashtablez_sampler.cc Expected to fix the android build. PiperOrigin-RevId: 228222550 GitOrigin-RevId: fd86c60bac6c41f1629ce1ab7dc1c8edff398a59 Change-Id: I26339fd4548c1a81b037cb52c26910d1bd850ea8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intrinsic
_umul128is only available on Windows X64, and not available on Windows ARM64, even both defined_WIN64.This issue is exposed when building abseil library in Chromium for Windows ARM64.
EDIT: Resend the PR using the email account I registered with corporate CLA.