Fix ABSL_RANDOM_RANDEN_COPTS setting on FreeBSD #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On FreeBSD amd64, both uname -p and uname -m returns amd64 (lowercase). It seems Windows returns AMD64 (uppercase). Reference: [1] https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_PROCESSOR.html [2] https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html
|
Thanks! |
absl-federation-github
pushed a commit
that referenced
this pull request
Apr 15, 2020
-- 2182f6d50e2bcb77858aaab6001ebffdc13bee89 by Derek Mauro <dmauro@google.com>: Use base_internal::AtomicHook instead of std::atomic for StatusPayloadPrinter Imports #661 PiperOrigin-RevId: 306514102 -- 6f8047057f4530c17c06ab1737a1937c86402807 by Mark Barolak <mbar@google.com>: Fix ABSL_RANDOM_RANDEN_COPTS setting on FreeBSD Import of #664 PiperOrigin-RevId: 306485774 -- cb3b73b9607d0009bbcfd7766f4f1fa4fde9c8b9 by Abseil Team <absl-team@google.com>: Avoid a -Wimplicit-int-float-conversion warning. Without this explicit cast, this code produces a warning of "implicit conversion from 'const int64_t' (aka 'const long') to 'double' may lose precision" when this warning is turned on. PiperOrigin-RevId: 306358838 -- ef895ea6b28c96b64531c218705bac9c3fa169d5 by Greg Falcon <gfalcon@google.com>: Internal change PiperOrigin-RevId: 306040909 GitOrigin-RevId: 2182f6d50e2bcb77858aaab6001ebffdc13bee89 Change-Id: I69555c1722745a74c1603c62a621ca765d253fe5
absl-federation-github
pushed a commit
that referenced
this pull request
Sep 23, 2020
- d3614de Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 20feb1c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c1ae0a4 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 6af91b3 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - f2c9c66 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 3c8b5d7 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 7ba8cdb Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 930fbec Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 0e9921b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a4cbb5f Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4d2ff38 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c03c18e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b321ad8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - fbf0fda Export of internal Abseil changes by Abseil Team <absl-team@google.com> - dc969f3 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d0c4334 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c6b3f2c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1beb319 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1b7e751 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ce4bc92 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - f72cc35 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - f66bc74 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1995c6a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 184cf25 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 82302f1 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - dea7648 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d39fe6c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2c8a5b0 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 41a6263 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 3c2bed2 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ea8a689 fix build on P9 (#739) by jglaser <glaserj@ornl.gov> - 672d9e0 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - f624790 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 55c04eb Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 302b250 Disable pthread for standalone wasm build support (#721) by Rei Shimizu <Shikugawa@gmail.com> - 61d8bc0 Merge branch 'master' of https://github.com/abseil/abseil... by Gennadiy Rozental <rogeeff@google.com> - d5269a8 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bf655de Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 38db52a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 81f34df Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b86fff1 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 10cb35e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4ccc0fc Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4a85104 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ccdbb59 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 01f5f81 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2c92bdc Export of internal Abseil changes by Abseil Team <absl-team@google.com> - e7ebf98 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2eba343 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a8b03d9 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1d31b5c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - da3a876 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 8faf204 Exclude empty directories (#697) by Po-Chuan Hsieh <sunpoet@sunpoet.net> - 2069dc7 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 4832bf6 Added a BUILD file in root to expose license. (#695) by Dylan Madisetti <dylan.madisetti@gmail.com> - af8f994 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 33caf10 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - cf1a02e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 768eb2c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 3f347c4 Fix build on riscv32 (#675) by Khem Raj <raj.khem@gmail.com> - 62cf6a7 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - d118d4b Export of internal Abseil changes by Abseil Team <absl-team@google.com> - f2bc9d1 Fix public target name of the random library (#684) by Nicholas Bishop <nicholasbishop@gmail.com> - 0fecf0e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - cbfd0f0 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c45d1c0 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a35ef8a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - bd317ca Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b115744 fix MSVC warning 4245: conversion signed => unsigned duri... by Christoph Cullmann <cullmann@kde.org> - d85783f Export of internal Abseil changes by Abseil Team <absl-team@google.com> - a1d6689 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - ca9856c Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 6e18c71 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 3f48ce1 init (#673) by Fu Zhe <fuzhe1989@gmail.com> - cde2e24 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 68494aa Fix CMake Threads dependency issue by Zach Toogood <zach@yousician.com> - 902909a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - cb52b05 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1a02b7a Use "-lrt" instead of the resolved find_library result wh... by László Nagy <rizsotto@users.noreply.github.com> - df60c82 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b35973e Export of internal Abseil changes by Abseil Team <absl-team@google.com> - db5773a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 71079e4 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2946ac0 Use base_internal::AtomicHook instead of std::atomic (#661) by Pavel Samolysov <samolisov@gmail.com> - 567bee2 Fix ABSL_RANDOM_RANDEN_COPTS setting on FreeBSD (#664) by Po-Chuan Hsieh <sunpoet@sunpoet.net> - bf6166a Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 1112609 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 73ea9a9 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c01b991 Add option to use an externally provided GoogleTest targ... by Adrian Imboden <adi@thingdust.com> - d43b799 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 62f05b1 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - fba8a31 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 79e0dc1 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 132d791 bazel: Add missing load statements for cc_binary (#645) by Yannic <contact@yannic-bonenberger.com> - 518f175 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 092ed97 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 2d2a8ae Export of internal Abseil changes by Abseil Team <absl-team@google.com> - 7853a75 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - c695489 Export of internal Abseil changes by Abseil Team <absl-team@google.com> - b92f35f Fix CompressedTuple move constructor on MSVC (#637) by i-do-cpp <62053234+i-do-cpp@users.noreply.github.com> (And 9 more changes) GitOrigin-RevId: d3614de Change-Id: I589267fa36251e17cd1e95061b702edcafd1a3ad
rongjiecomputer
pushed a commit
to rongjiecomputer/abseil-cpp
that referenced
this pull request
Oct 8, 2020
* Fix build on FreeBSD On FreeBSD amd64, both uname -p and uname -m returns amd64 (lowercase). It seems Windows returns AMD64 (uppercase). Reference: [1] https://cmake.org/cmake/help/latest/variable/CMAKE_SYSTEM_PROCESSOR.html [2] https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html * Use MATCHES for multiple values
rongjiecomputer
pushed a commit
to rongjiecomputer/abseil-cpp
that referenced
this pull request
Oct 8, 2020
-- 2182f6d50e2bcb77858aaab6001ebffdc13bee89 by Derek Mauro <dmauro@google.com>: Use base_internal::AtomicHook instead of std::atomic for StatusPayloadPrinter Imports abseil#661 PiperOrigin-RevId: 306514102 -- 6f8047057f4530c17c06ab1737a1937c86402807 by Mark Barolak <mbar@google.com>: Fix ABSL_RANDOM_RANDEN_COPTS setting on FreeBSD Import of abseil#664 PiperOrigin-RevId: 306485774 -- cb3b73b9607d0009bbcfd7766f4f1fa4fde9c8b9 by Abseil Team <absl-team@google.com>: Avoid a -Wimplicit-int-float-conversion warning. Without this explicit cast, this code produces a warning of "implicit conversion from 'const int64_t' (aka 'const long') to 'double' may lose precision" when this warning is turned on. PiperOrigin-RevId: 306358838 -- ef895ea6b28c96b64531c218705bac9c3fa169d5 by Greg Falcon <gfalcon@google.com>: Internal change PiperOrigin-RevId: 306040909 GitOrigin-RevId: 2182f6d50e2bcb77858aaab6001ebffdc13bee89 Change-Id: I69555c1722745a74c1603c62a621ca765d253fe5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error message is as follows: