Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build on P9 #739

Merged
merged 1 commit into from
Jul 17, 2020
Merged

fix build on P9 #739

merged 1 commit into from
Jul 17, 2020

Conversation

jglaser
Copy link
Contributor

@jglaser jglaser commented Jul 11, 2020

This PR fixes the following build error when compiling grpc on Summit / Power9:

[ 10%] Building CXX object third_party/abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_hwaes_impl.dir/internal/randen_hwaes.cc.o
[ 10%] Building CXX object third_party/protobuf/CMakeFiles/libprotobuf.dir/__/src/google/protobuf/io/zero_copy_stream_impl.cc.o
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc: In member function 'constexpr __vector(4) __bool int {anonymous}::u64x2::operator==(const {anonymous}::u64x2&) const':
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:323:51: error: cannot convert 'bool' to '__vector(4) __bool int' in return
     return v[0] == other.v[0] && v[1] == other.v[1];
                                                   ^
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:324:3: error: body of constexpr function 'constexpr __vector(4) __bool int {anonymous}::u64x2::operator==(const {anonymous}::u64x2&) const' not a return-statement
   }
   ^
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc: At global scope:
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:389:1: error: non-constant condition for static assertion
 static_assert(round_keys[kKeys - 1] != u64x2(0, 0),
 ^~~~~~~~~~~~~
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:389:37:   in constexpr expansion of '{anonymous}::round_keys[(136 - 1)].{anonymous}::u64x2::operator!=({anonymous}::u64x2(0, 0)'
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:327:20: error: constexpr __vector(4) __bool int {anonymous}::u64x2::operator==(const {anonymous}::u64x2&) const' called in a constant expression
     return !(*this == other);
             ~~~~~~~^~~~~~~~~
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc: In function '__vector(4) __bool int absl::lts_2020_02_25::random_internal::HasRandenHwAesImplementation()':
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:526:6: error: ambiguating new declaration of '__vector(4) __bool int absl::lts_2020_02_25::random_internal::HasRandenHwAesImplementation()'
 bool HasRandenHwAesImplementation() { return true; }
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:20:0:
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.h:44:6: note: old declaration 'bool absl::lts_2020_02_25::random_internal::HasRandenHwAesImplementation()'
 bool HasRandenHwAesImplementation();
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/ccs/proj/stf006/glaser/rapids/grpc/third_party/abseil-cpp/absl/random/internal/randen_hwaes.cc:526:46: error: cannot convert 'bool' to '__vector(4) __bool int' in return
 bool HasRandenHwAesImplementation() { return true; }
                                              ^~~~
make[2]: *** [third_party/abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_hwaes_impl.dir/internal/randen_hwaes.cc.o] Error 1
make[1]: *** [third_party/abseil-cpp/absl/random/CMakeFiles/absl_random_internal_randen_hwaes_impl.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jglaser
Copy link
Contributor Author

jglaser commented Jul 11, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@vslashg vslashg merged commit ea8a689 into abseil:master Jul 17, 2020
absl-federation-github pushed a commit that referenced this pull request Jul 20, 2020
--
763b4755cc65db94fb1d6c09655f77deee685698 by Evan Brown <ezb@google.com>:

Rollback change getting rid of recursion in clear_and_delete().

PiperOrigin-RevId: 322156175

--
e430ae6970ae2e76357876449878033e3c72e734 by Greg Falcon <gfalcon@google.com>:

fix build on P9

Import of #739

PiperOrigin-RevId: 321855200

--
3076c5bf811a950e7f7914023434d4aa9c0fbbb0 by Derek Mauro <dmauro@google.com>:

Check for the existence of CMake policies before using them
Fixes #742

PiperOrigin-RevId: 321798698
GitOrigin-RevId: 763b4755cc65db94fb1d6c09655f77deee685698
Change-Id: I641e42f8bebe236b75f1bf1116a129c2ad9b2571
absl-federation-github pushed a commit that referenced this pull request Sep 23, 2020
  - d3614de Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 20feb1c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c1ae0a4 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 6af91b3 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - f2c9c66 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 3c8b5d7 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 7ba8cdb Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 930fbec Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 0e9921b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a4cbb5f Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4d2ff38 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c03c18e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b321ad8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - fbf0fda Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - dc969f3 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d0c4334 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c6b3f2c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1beb319 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1b7e751 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ce4bc92 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - f72cc35 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - f66bc74 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1995c6a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 184cf25 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 82302f1 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - dea7648 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d39fe6c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2c8a5b0 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 41a6263 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 3c2bed2 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ea8a689 fix build on P9 (#739) by jglaser <glaserj@ornl.gov>
  - 672d9e0 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - f624790 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 55c04eb Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 302b250 Disable pthread for standalone wasm build support (#721) by Rei Shimizu <Shikugawa@gmail.com>
  - 61d8bc0 Merge branch 'master' of https://github.com/abseil/abseil... by Gennadiy Rozental <rogeeff@google.com>
  - d5269a8 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bf655de Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 38db52a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 81f34df Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b86fff1 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 10cb35e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4ccc0fc Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4a85104 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ccdbb59 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 01f5f81 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2c92bdc Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - e7ebf98 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2eba343 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a8b03d9 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1d31b5c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - da3a876 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 8faf204 Exclude empty directories (#697) by Po-Chuan Hsieh <sunpoet@sunpoet.net>
  - 2069dc7 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 4832bf6 Added a BUILD file in root to expose license. (#695) by Dylan Madisetti <dylan.madisetti@gmail.com>
  - af8f994 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 33caf10 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - cf1a02e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 768eb2c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 3f347c4 Fix build on riscv32 (#675) by Khem Raj <raj.khem@gmail.com>
  - 62cf6a7 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - d118d4b Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - f2bc9d1 Fix public target name of the random library (#684) by Nicholas Bishop <nicholasbishop@gmail.com>
  - 0fecf0e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - cbfd0f0 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c45d1c0 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a35ef8a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - bd317ca Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b115744 fix MSVC warning 4245: conversion signed => unsigned duri... by Christoph Cullmann <cullmann@kde.org>
  - d85783f Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - a1d6689 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - ca9856c Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 6e18c71 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 3f48ce1 init (#673) by Fu Zhe <fuzhe1989@gmail.com>
  - cde2e24 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 68494aa Fix CMake Threads dependency issue by Zach Toogood <zach@yousician.com>
  - 902909a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - cb52b05 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1a02b7a Use "-lrt" instead of the resolved find_library result wh... by László Nagy <rizsotto@users.noreply.github.com>
  - df60c82 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b35973e Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - db5773a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 71079e4 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2946ac0 Use base_internal::AtomicHook instead of std::atomic (#661) by Pavel Samolysov <samolisov@gmail.com>
  - 567bee2 Fix ABSL_RANDOM_RANDEN_COPTS setting on FreeBSD (#664) by Po-Chuan Hsieh <sunpoet@sunpoet.net>
  - bf6166a Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 1112609 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 73ea9a9 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c01b991  Add option to use an externally provided GoogleTest targ... by Adrian Imboden <adi@thingdust.com>
  - d43b799 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 62f05b1 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - fba8a31 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 79e0dc1 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 132d791 bazel: Add missing load statements for cc_binary (#645) by Yannic <contact@yannic-bonenberger.com>
  - 518f175 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 092ed97 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 2d2a8ae Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - 7853a75 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - c695489 Export of internal Abseil changes by Abseil Team <absl-team@google.com>
  - b92f35f Fix CompressedTuple move constructor on MSVC (#637) by i-do-cpp <62053234+i-do-cpp@users.noreply.github.com>
  (And 9 more changes)

GitOrigin-RevId: d3614de
Change-Id: I589267fa36251e17cd1e95061b702edcafd1a3ad
rongjiecomputer pushed a commit to rongjiecomputer/abseil-cpp that referenced this pull request Oct 8, 2020
rongjiecomputer pushed a commit to rongjiecomputer/abseil-cpp that referenced this pull request Oct 8, 2020
--
763b4755cc65db94fb1d6c09655f77deee685698 by Evan Brown <ezb@google.com>:

Rollback change getting rid of recursion in clear_and_delete().

PiperOrigin-RevId: 322156175

--
e430ae6970ae2e76357876449878033e3c72e734 by Greg Falcon <gfalcon@google.com>:

fix build on P9

Import of abseil#739

PiperOrigin-RevId: 321855200

--
3076c5bf811a950e7f7914023434d4aa9c0fbbb0 by Derek Mauro <dmauro@google.com>:

Check for the existence of CMake policies before using them
Fixes abseil#742

PiperOrigin-RevId: 321798698
GitOrigin-RevId: 763b4755cc65db94fb1d6c09655f77deee685698
Change-Id: I641e42f8bebe236b75f1bf1116a129c2ad9b2571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants