Fix/add tests for compile time default value evaluation #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-chong
commented
Jan 7, 2021
| @@ -169,7 +169,6 @@ defmodule Absinthe.Blueprint.Schema do | |||
| end | |||
|
|
|||
| defp build_types([:close | rest], [%Schema.InputValueDefinition{} = arg, field | stack], buff) do | |||
| arg = Map.update!(arg, :default_value, fn val -> {:unquote, [], [val]} end) | |||
There was a problem hiding this comment.
Seemed to not work, and i'm guess it was supposed to do the evaluation. Clearly it didn't so just removed and used the wrap_in_unquote function. Tests are passing anyway
dylan-chong
commented
Jan 7, 2021
test/absinthe/type/object_test.exs
Outdated
|
|
||
| assert type.fields[unquote(test_label)].default_value == unquote(expected_value) | ||
| end | ||
| end) |
There was a problem hiding this comment.
the input object's field's default_value is always nil here. Not sure if intentional or not. But i have removed this test in ffb7a0c for the time being
|
@binaryseed Would this be able to make it into 1.6? I found this issue testing 1.6.0-rc-0 on my company's codebase |
dylan-chong
commented
Jan 7, 2021
| @@ -1,68 +1,51 @@ | |||
| defmodule Absinthe.Type.QueryTest do | |||
| use Absinthe.Case, async: true | |||
|
|
|||
| defmodule TestSchema do | |||
There was a problem hiding this comment.
moved to fixtures
|
Thanks for this! |
dylan-chong
deleted the
fix/add-tests-for-compile-time-default_value-evaluation
branch
dylan-chong
restored the
fix/add-tests-for-compile-time-default_value-evaluation
branch
dylan-chong
deleted the
fix/add-tests-for-compile-time-default_value-evaluation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.