Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better solve deadlocks on Elixir v1.12+ #1056

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Better solve deadlocks on Elixir v1.12+ #1056

merged 2 commits into from
Mar 26, 2021

Conversation

josevalim
Copy link
Contributor

Closes #937.

@josevalim
Copy link
Contributor Author

There is a dialyzer warning because the function is not available in certain Elixir versions so we need an annotation somewhere to address it - but I am not sure which one. If someone can address that, it would be very appreciated.

@binaryseed binaryseed changed the base branch from master to fix-deadlocks March 26, 2021 20:35
@binaryseed
Copy link
Contributor

Thanks! I'll see if I can get the warnings resolved

@binaryseed binaryseed merged commit b7779ee into absinthe-graphql:fix-deadlocks Mar 26, 2021
@binaryseed binaryseed mentioned this pull request Mar 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import_types breaking change
2 participants
@josevalim @binaryseed