Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better solve deadlocks on Elixir v1.12+ #1057

Merged
merged 3 commits into from
Mar 26, 2021
Merged

Better solve deadlocks on Elixir v1.12+ #1057

merged 3 commits into from
Mar 26, 2021

Conversation

binaryseed
Copy link
Contributor

From #1056 with a dialyzer fix

benwilson512
benwilson512 approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. Hopefully we can obviate this by moving more things to persistent term and runtime calls, but this is good regardless.

I've actually finally reproduced this locally, so I'll be able to test that runtime oriented approaches fix the issue.

@binaryseed binaryseed merged commit 659d15d into master Mar 26, 2021
@binaryseed binaryseed deleted the fix-deadlocks branch March 26, 2021 23:30
@maartenvanvliet maartenvanvliet mentioned this pull request Jan 24, 2022
Closed
@maartenvanvliet maartenvanvliet mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwilson512 benwilson512 benwilson512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@binaryseed @benwilson512