Ensure input/output types are correctly placed for SDL schemas #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The InputOutputTypesCorrectlyPlaced phase did not work for SDL schema's since it would unwrap a TypeReference, which yields the TypeReference and not the type atom. The subsequent lookup in the schema types would therefore fail, as it expects atoms not typereferences, and it would not add errors. It now correctly fetches the atom type identifier, though in a bit of a roundabout way.
maartenvanvliet
commented
Jan 18, 2022
| end | ||
|
|
||
| test "is enforced with input types on arguments" do | ||
| assert_schema_error("invalid_input_types_sdl", [ |
There was a problem hiding this comment.
This test asserts there are two errors, whilst the macro based schema only has one. This points to an issue with the macro based schema in that input object fields are FieldDefinition structs and not InputValueDefinition structs like there are in the SDL schema.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The InputOutputTypesCorrectlyPlaced phase did not work for
SDL schema's since it would unwrap a TypeReference, which
yields the TypeReference and not the atom type identifier.
The subsequent lookup in the schema types would therefore fail, as
it expects atoms not typereferences, and it would not add errors.
It now correctly fetches the atom type identifier, though in a bit of
a roundabout way.