Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure input/output types are correctly placed for SDL schemas #1142

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Ensure input/output types are correctly placed for SDL schemas #1142

merged 1 commit into from
Jan 18, 2022

Commits on Jan 18, 2022

  1. Ensure input/output types are correctly placed for SDL schemas 

    The InputOutputTypesCorrectlyPlaced phase did not work for
SDL schema's since it would unwrap a TypeReference, which
yields the TypeReference and not the type atom.

The subsequent lookup in the schema types would therefore fail, as
it expects atoms not typereferences, and it would not add errors.

It now correctly fetches the atom type identifier, though in a bit of
a roundabout way.
    @maartenvanvliet
    maartenvanvliet committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    ff3090e View commit details
    Browse the repository at this point in the history