-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add import_directives #1158
Add import_directives #1158
Conversation
9c7821a
to
d4c7a11
Compare
What do you think about moving the directive imports to a separate DirectiveImports phase? So each phase does only one thing and makes it easier to remove/change the separate schema phases. Same applies to type_extensions in #1157 btw. Should perhaps also be moved to a separate phase. |
d4c7a11
to
ad5c0fb
Compare
Alright got that feedback in and pulled that into a new |
@kdawgwilk this looks solid, let's rebase on the new master branch that has the formatter changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small thing: Can you add a changelog entry for this so that it stays up to date?
ad5c0fb
to
f2756b5
Compare
This is now rebased and changelog entry added 👍 |
Anything else I should include here? |
This is great, thank you! |
There is some duplication between import_types but this PR is still relatively small so I wasnt sure if I should spend much time refactoring this to reduce some of the duplication
Closes #1152