Fix interior field nullability checks #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#237) * Adding failing tests for enforcing non_null fields in input variables * simplifying the offending from a mutation to a query
benwilson512
commented
Dec 23, 2016
| @@ -28,6 +28,10 @@ defmodule Absinthe.Phase.Document.MissingLiterals do | |||
| fields = fill_missing_nodes(Blueprint.Input.Field, fields, schema_fields, node.source_location, adapter, schema) | |||
| %{node | fields: fields} | |||
| end | |||
| defp populate_node(%Blueprint.Input.Object{schema_node: %{of_type: type}} = node, adapter, schema) do | |||
| %{ node | schema_node: type} | |||
| |> populate_node(adapter, schema) | |||
There was a problem hiding this comment.
@nietaki in the end I just went with a recursive approach here.
| @@ -17,7 +17,7 @@ defmodule Absinthe.Blueprint.Input.Object do | |||
| @type t :: %__MODULE__{ | |||
| fields: [Blueprint.Input.Field.t], | |||
| flags: Blueprint.flags_t, | |||
| schema_node: nil | Absinthe.Type.InputObject.t, | |||
| schema_node: nil | Absinthe.Type.InputObject.t | Absinthe.Type.NonNull.t(Absinthe.Type.InputObject.t), | |||
There was a problem hiding this comment.
Fancy typespecs FTW
There was a problem hiding this comment.
I didn't even know you could do @type t(x) :: %__MODULE__{of_type: x}, good stuff.
| @@ -47,7 +47,18 @@ defmodule Absinthe.Execution.ArgumentsTest do | |||
| value :sms, deprecate: "Use phone instead" | |||
| end | |||
|
|
|||
There was a problem hiding this comment.
I moved the tests to arguments_test because that's generally where we've been doing these kinds of tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.