Use node_name/0 to check the node origin - 1.4

[thiamsantos]

Motivation

As reported on absinthe-graphql/absinthe_phoenix#63 the subscriptions messages are getting duplicated when using Redis Pubsub adapter.

Proposed solution

As pointed out by @benwilson512 the phoenix pubsub .... and the logic the code that performs this check was relying on a implementation detail of the PG2 adapter. This PR aims to change that verification to use the node_name function exposed by phoenix pubsub and wrapped by absinthe_phoenix for absinthe 1.4.

The implementation was manually tested against using this repo https://github.com/thiamsantos/subscription_test with both PG2 and redis as adapters.

Related

• Use node_name to check if the message is local - 1.5 #815

[benwilson512]

I see you've marked this as a draft, do you have other changes planned?

[thiamsantos]

@benwilson512 I'm planning to fully test it with both PG2 and redis adapters to make sure that no regressions will be introduced before marking as ready.

[thiamsantos]

@benwilson512 Sorry for the delay on it, I got myself a little free time today to properly test it.

I created two PRs in the hope to get a patch version for the absinthe 1.4 the one that we use in production.

• Use node_name/0 to check the node origin - 1.4 #814 - PR for version 1.4
• Use node_name to check if the message is local - 1.5 #815 - PR for version 1.5

I would love some feedback on those PRs :)

[benwilson512]

Looks great! I'll cut releases later today.

[philipbrown]

Was a 1.4 release created with this fix?

[benwilson512]

Quite possibly not. Will do.