Use node_name to check if the message is local - 1.5 #815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As reported on absinthe-graphql/absinthe_phoenix#63 the subscriptions messages are getting duplicated when using Redis Pubsub adapter.
Proposed solution
As pointed out by @benwilson512 the phoenix pubsub .... and the logic the code that performs this check was relying on a implementation detail of the PG2 adapter. This PR aims to change that verification to use the
node_namefunction exposed by phoenix pubsub and wrapped byabsinthe_phoenixfor absinthe 1.5.The implementation was manually tested against using this repo https://github.com/thiamsantos/subscription_test with both PG2 and redis as adapters.
Related