Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance settings for scheme scoping. #36

Open
wahidrahim opened this issue Aug 22, 2014 · 2 comments
Open

Enhance settings for scheme scoping. #36

wahidrahim opened this issue Aug 22, 2014 · 2 comments

Comments

@wahidrahim
Copy link

I noticed this for http://heroku.com/. If I disable it at the main page, once I log in it is back to being inverted. Furthermore if I disable it then, the next link I click is deluminated and I end of disabling it for every page.

I think it would be great if users had a settings option where you can add "excluded sites" and could use wildcards: e.g. "Exclude: *.heroku.com_, https://www.youtube.com/watch?_"

@abstiles
Copy link
Owner

Looks like heroku.com takes you to www.heroku.com, and upon logging in you're redirected to dashboard.heroku.com. Clicking "databases" takes you to postgres.heroku.com, Add-ons takes you to addons.heroku.com, and so on, with each major section of a page given its own subdomain. How obnoxious!

Okay, so Deluminate treats every subdomain independently because there are a lot of times subdomains behave differently enough to warrant different inversion rules. Clearly the heroku site is rather pathological from this standpoint, though. You can just deal with it for now by manually choosing "Normal" for the page every time you hit a new subdomain, and it will remember it in the future (so the next time you land on, e.g., dashboard.heroku.com, it will be fine).

Down the road, I'm interested in adding more granular preferences for sites. I'd like the user to be able to easily set a scheme for all subdomains of a domain, and even for parts of a web page's path. I'm actually surprised I don't already have an issue here for that enhancement.

@abstiles abstiles changed the title Deluminate is not being disabled for the entire site. Enhance settings for scheme scoping. Aug 22, 2014
@wahidrahim
Copy link
Author

Ah then the heroku website is a slightly different case, I understand now. I will bare with disabling for whatever page for now. The enhanced settings will be a great and powerful addition to this extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants