Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update citation #8

Open
2 tasks
sarahzrf opened this issue Jun 29, 2016 · 5 comments
Open
2 tasks

Update citation #8

sarahzrf opened this issue Jun 29, 2016 · 5 comments
Assignees
Milestone

Comments

@sarahzrf
Copy link
Contributor

sarahzrf commented Jun 29, 2016

What should I do about the copyright notices?

They're in the following files:

  • lib/ecell/base/sketches/webstack/puma.rb
  • lib/ecell/base/sketches/webstack/web_server.rb
@digitalextremist
Copy link
Contributor

digitalextremist commented Jul 20, 2016

Copyright in this case will be severally: Donovan Keme, Ben SURNAME, Celluloid Framework Corporation, EnergyOne Limited with/in #9 LICENSE.txt or equivalent.

@sarahzrf
Copy link
Contributor Author

Sorry, let me clarify: I meant the ones that were already present in a couple of the webstack files, like this:

  # Author: Harley Mackenzie
  #
  # Copyright (c) 2014 Energy One Limited

@sarahzrf sarahzrf reopened this Jul 20, 2016
@sarahzrf sarahzrf self-assigned this Jul 20, 2016
@digitalextremist
Copy link
Contributor

That citation is not applicable to ECell but to a piece of the old code. Specifically a subsystem taken out.

@sarahzrf
Copy link
Contributor Author

It's still in lib/ecell/base/sketches/webstack/puma.rb and lib/ecell/base/sketches/webstack/web_server.rb - should I remove it from those?

@digitalextremist
Copy link
Contributor

@benzrf if you edit the ticket to make it a checklist of locations showing citation, I will take this myself and handle it during the "pencils down" period, but just before the final.

@digitalextremist digitalextremist modified the milestone: GSoC 2016 Jul 28, 2016
@sarahzrf sarahzrf removed their assignment Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants