Update/Must use on abstract sdk methods

[Buckram123]

This adds warnings on unused AccountAction and unused CosmosMsg from the Executor

• Helpfully add_message and add_messages takes impl Into<CosmosMsg<T>>, so it shouldn't affect users.
• Unfortunately add_submessage takes raw SubMsg<T>.

So we still have an issue: we can't implement message wrapper with unused warning for unused SubMsg, because it will require users to cast it using "into" every time

Checklist

• CI is green.
• Changelog updated.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	205ddfd
Status:	✅  Deploy successful!
Preview URL:	https://c544bf8d.abstract-docs.pages.dev
Branch Preview URL:	https://buckram-abs-194-add-must-use.abstract-docs.pages.dev

View logs

[Kayanski]

It's already something that the sdk provides helpers for simple message mechanisms.
For messages with replies, I think we can assume that developers are more advanced and will not forget to use the message result !

[Kayanski]

Shouldn't we have a single way of executing all those actions ?
We could pass the DepositMsgs and AccountAction all to the executor and it would decide what to do with it ?
So that the sdk would always create something you have to pass to the executor and then to the Response::add_messagesfunction ?

[Buckram123]

Shouldn't we have a single way of executing all those actions ? We could pass the DepositMsgs and AccountAction all to the executor and it would decide what to do with it ? So that the sdk would always create something you have to pass to the executor and then to the Response::add_messagesfunction ?

Right now executor executes actions only from the proxy, idk if we want to expand that. DepositMsgs sends funds from this contract to the proxy, so it's not an action from the proxy

[CyberHoward]

Shouldn't we have a single way of executing all those actions ? We could pass the DepositMsgs and AccountAction all to the executor and it would decide what to do with it ? So that the sdk would always create something you have to pass to the executor and then to the Response::add_messagesfunction ?

Right now executor executes actions only from the proxy, idk if we want to expand that. DepositMsgs sends funds from this contract to the proxy, so it's not an action from the proxy

I think Nicolas brings up a good point. The executor API is kind of confusing but IMO we should stick with it for now. We can look into removing the need for Response construction entirely by having a call stack inside the module struct itself and executing that stack at the end of a contract's execution.