Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POD coverage fail [rt.cpan.org #74388] #156

Closed
atoomic opened this issue Oct 5, 2018 · 1 comment
Closed

POD coverage fail [rt.cpan.org #74388] #156

atoomic opened this issue Oct 5, 2018 · 1 comment

Comments

@atoomic
Copy link
Collaborator

atoomic commented Oct 5, 2018

Migrated from rt.cpan.org#74388 (status was 'open')

Requestors:

From zefram@fysh.org on 2012-01-25 19:50:48:

Template-Toolkit-2.23 fails its test suite under AUTOMATED_TESTING:

t/zz-pod-coverage.t ... 1/7 
#   Failed test 'Pod coverage on Template'
#   at t/zz-pod-coverage.t line 29.
# Coverage for Template is 75.0%, with 1 naked subroutine:
#       template
# Looks like you failed 1 test of 7.
t/zz-pod-coverage.t ... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/7 subtests 

I'm using AUTOMATED_TESTING to suppress interactive aspects of some module installs. I see TT is using its other meaning, of enabling extra tests.

-zefram

From @karenetheridge on 2016-06-23 20:16:25:

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, both of which cannot be predicted in advance.

Either move them to xt/, or guard them with:

plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING}; 
@toddr
Copy link
Collaborator

toddr commented Oct 5, 2018

This isn't failing any more but I see no reason not to remove AUTOMATED_TESTING

toddr added a commit that referenced this issue Oct 6, 2018
toddr added a commit that referenced this issue Oct 8, 2018
@toddr toddr closed this as completed in #187 Oct 8, 2018
toddr added a commit that referenced this issue Oct 8, 2018
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 24, 2018
Upstream changes:
Version 2.28 - 11th October 2018
#------------------------------------------------------------------------

* Add and enable Travis CI to track GitHub Pull Requests

* Template is now using GitHub as the official Bug Tracker

* Nicolas R. fixed a circular reference in Template::Plugin::Filter
  abw/Template2#152

* Nicolas R. adjusted group regexes to not be greedy
  abw/Template2#94

* Nicolas R. added unit tests to cover regression from RT 91172
  abw/Template2#122

* Nicolas R. added support for template files having mtime=0
  abw/Template2#102

* Todd Rinaldo fixed rand calls with no args in Math plugin
  abw/Template2#155

* Todd Rinaldo corrected ttree 2.22 logic change
  abw/Template2#148

* Todd Rinaldo turned off automated testing for tests using optional modules
  abw/Template2#156

* Nicolas R. adjusted unit tests to not force Stash::XS

* Nicolas R. added a pre allocated buffer in Stash.xs to avoid malloc/free
  abw/Template2#82

* Nicolas R. optmized Template::Parser by avoiding a dummy sub
  abw/Template2#83

* Nicolas R. optimized Template:Directive by using index
  abw/Template2#84

* Nicolas R. adjust _dotop logic in Stash for perl 5.28 and earlier
  abw/Template2#81

* Todd Rinaldo documented VMethod method called 'item'
  abw/Template2#90

* Nicolas R. adjusted t/filter.t after recent switch to RFC3986
  abw/Template2#179

* Nicolas R. fixed warnings from t/cgi.t
  abw/Template2#178

* Ivan Krylov added STRICT option to ttree
  abw/Template2#81

* Kent Fredric fixed relative path handling in templates on Perl 5.26+
  abw/Template2#80

* Tom Delmas fixed some typo from documentation
  abw/Template2#76

* Matthew Somerville switched uri/url to use RFC3986
  updated the documentation to match the history.
  abw/Template2#35

* Sebastien Deseille used remove_tree helper to remove directories
  abw/Template2#67

* Nick Hibma - Add Sortkeys to DUMPER_ARGS
  abw/Template2#64

* E. Choroba added a warn on duplicate block name
  abw/Template2#61

* Jason Lewis fixed some typo in ttree.pod
  abw/Template2#58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants