Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t/filter.t is currently failing #179

Closed
atoomic opened this issue Oct 5, 2018 · 1 comment
Closed

t/filter.t is currently failing #179

atoomic opened this issue Oct 5, 2018 · 1 comment
Assignees
@atoomic
Labels
Test Suite

Comments

@atoomic
Copy link
Collaborator

atoomic commented Oct 5, 2018

view travis https://travis-ci.org/abw/Template2/jobs/437782131

prove -vl t/filter.t
t/filter.t ..
1..162
ok 1 - running test_expect()
ok 2 - template processor is engaged
ok 3 - input read and split into 79 tests
ok 4 - template text 1 processed OK: [% TRY %]\n[% FILTER nonfilt %]\nb...
ok 5 - template text 1 matched expected
ok 6 - template text 2 processed OK: [% TRY %]\n[% FILTER badfact %]\nb...
ok 7 - template text 2 matched expected
ok 8 - template text 3 processed OK: [% TRY %]\n[% FILTER badfilt %]\nb...
ok 9 - template text 3 matched expected
ok 10 - template text 4 processed OK: [% TRY;\n     "foo" | barfilt;\n  ...
ok 11 - template text 4 matched expected
ok 12 - template text 5 processed OK: [% TRY;\n     "foo" | barfilt(1);...
ok 13 - template text 5 matched expected
ok 14 - template text 6 processed OK: [% TRY;\n     "foo" | barfilt(2);...
ok 15 - template text 6 matched expected
ok 16 - template text 7 processed OK: [% TRY;\n     "foo" | barfilt(3);...
ok 17 - template text 7 matched expected
ok 18 - template text 8 processed OK: [% FILTER html %]\nThis is some h...
ok 19 - template text 8 matched expected
ok 20 - template text 9 processed OK: [% text = "The <cat> sat on the ...
ok 21 - template text 9 matched expected
ok 22 - template text 10 processed OK: [% text = "The <cat> sat on the ...
ok 23 - template text 10 matched expected
ok 24 - template text 11 processed OK: [% FILTER html %]\n"It isn't what...
ok 25 - template text 11 matched expected
ok 26 - template text 12 processed OK: [% FILTER xml %]\n"It isn't what ...
ok 27 - template text 12 matched expected
ok 28 - template text 13 processed OK: [% FILTER format %]\nHello World!...
ok 29 - template text 13 matched expected
ok 30 - template text 14 processed OK: [% FILTER comment = format('<!--...
ok 31 - template text 14 matched expected
ok 32 - template text 15 processed OK: [% FILTER format %]\nHello World!...
ok 33 - template text 15 matched expected
ok 34 - template text 16 processed OK: [% "Foo" FILTER test1 = format('...
ok 35 - template text 16 matched expected
ok 36 - template text 17 processed OK: [% FILTER microjive %]\nThe "Hall...
ok 37 - template text 17 matched expected
ok 38 - template text 18 processed OK: [% FILTER microsloth %]\nThe "Hal...
ok 39 - template text 18 matched expected
ok 40 - template text 19 processed OK: [% FILTER censor('bottom' 'nippl...
ok 41 - template text 19 matched expected
ok 42 - template text 20 processed OK: [% FILTER bold = format('<b>%s</...
ok 43 - template text 20 matched expected
ok 44 - template text 21 processed OK: [% "foo" FILTER format("<< %s >>...
ok 45 - template text 21 matched expected
ok 46 - template text 22 processed OK: [% blocktext = BLOCK %]\nThe cat ...
ok 47 - template text 22 matched expected
ok 48 - template text 23 processed OK: [% global.blocktext FILTER html_...
ok 49 - template text 23 matched expected
ok 50 - template text 24 processed OK: [% global.blocktext FILTER html_...
ok 51 - template text 24 matched expected
ok 52 - template text 25 processed OK: [% global.blocktext FILTER html_...
ok 53 - template text 25 matched expected
ok 54 - template text 26 processed OK: [% global.blocktext FILTER html_...
ok 55 - template text 26 matched expected
ok 56 - template text 27 processed OK: [% global.blocktext FILTER trunc...
ok 57 - template text 27 matched expected
ok 58 - template text 28 processed OK: [% global.blocktext FILTER trunc...
ok 59 - template text 28 matched expected
ok 60 - template text 29 processed OK: [% 'Hello World' | truncate(2) +...
ok 61 - template text 29 matched expected
ok 62 - template text 30 processed OK: [% "foo..." FILTER repeat(5) %]
ok 63 - template text 30 matched expected
ok 64 - template text 31 processed OK: [% FILTER truncate(21) %]\nI have...
ok 65 - template text 31 matched expected
ok 66 - template text 32 processed OK: [% FILTER truncate(25) %]\nNothin...
ok 67 - template text 32 matched expected
ok 68 - template text 33 processed OK: [% FILTER repeat(3) %]\nAm I repe...
ok 69 - template text 33 matched expected
ok 70 - template text 34 processed OK: [% text FILTER remove(' ') +%]\n[...
ok 71 - template text 34 matched expected
ok 72 - template text 35 processed OK: [% text FILTER replace(' ', '_')...
ok 73 - template text 35 matched expected
ok 74 - template text 36 processed OK: [% text = 'The <=> operator' %]\n...
ok 75 - template text 36 matched expected
ok 76 - template text 37 processed OK: [% text = 'The <=> operator, bla...
ok 77 - template text 37 matched expected
ok 78 - template text 38 processed OK: [% | truncate(25) %]\nThe cat sat...
ok 79 - template text 38 matched expected
ok 80 - template text 39 processed OK: [% FILTER upper %]\nThe cat sat o...
ok 81 - template text 39 matched expected
ok 82 - template text 40 processed OK: [% FILTER lower %]\nThe cat sat o...
ok 83 - template text 40 matched expected
ok 84 - template text 41 processed OK: [% 'arse' | stderr %]\nstderr: [%...
ok 85 - template text 41 matched expected
ok 86 - template text 42 processed OK: [% percent = '%'\n   left    = "[...
ok 87 - template text 42 matched expected
ok 88 - template text 43 processed OK: [% TRY %]\n[% dir = "[\% FOREACH ...
ok 89 - template text 43 matched expected
ok 90 - template text 44 processed OK: nothing\n[% TRY;\n    '$x = 10; $b...
ok 91 - template text 44 matched expected
ok 92 - template text 45 processed OK: [% TRY -%]\nbefore\n[% FILTER redi...
ok 93 - template text 45 matched expected
ok 94 - template text 46 processed OK: [% FILTER evalperl %]\n   $a = 10...
ok 95 - template text 46 matched expected
ok 96 - template text 47 processed OK: [% TRY -%]\nbefore\n[% FILTER file...
ok 97 - template text 47 matched expected
ok 98 - template text 48 processed OK: [% PERL %]\n$Template::Filters::F...
ok 99 - template text 48 matched expected
ok 100 - template text 49 processed OK: [% PERL %]\n$Template::Filters::F...
ok 101 - template text 49 matched expected
ok 102 - template text 50 processed OK: [% PERL %]\n$stash->set('merlyn',...
ok 103 - template text 50 matched expected
ok 104 - template text 51 processed OK: [% PERL %]\n$stash->set('merlyn',...
ok 105 - template text 51 matched expected
ok 106 - template text 52 processed OK: [% myfilter = 'html' -%]\n[% FILT...
ok 107 - template text 52 matched expected
ok 108 - template text 53 processed OK: [% FILTER $despace -%]\nblah blah...
ok 109 - template text 53 matched expected
ok 110 - template text 54 processed OK: [% PERL %]\n$context->filter(\&ne...
ok 111 - template text 54 matched expected
ok 112 - template text 55 processed OK: [% PERL %]\n$context->define_filt...
ok 113 - template text 55 matched expected
ok 114 - template text 56 processed OK: [% FILTER another(3) -%]\nfoo bar...
ok 115 - template text 56 matched expected
ok 116 - template text 57 processed OK: [% '$stash->{ a } = 25' FILTER e...
ok 117 - template text 57 matched expected
ok 118 - template text 58 processed OK: [% '$stash->{ a } = 25' FILTER p...
ok 119 - template text 58 matched expected
ok 120 - template text 59 processed OK: [% FILTER indent -%]\nThe cat sat...
ok 121 - template text 59 matched expected
ok 122 - template text 60 processed OK: [% FILTER indent(2) -%]\nThe cat ...
ok 123 - template text 60 matched expected
ok 124 - template text 61 processed OK: [% FILTER indent('>> ') -%]\nThe ...
ok 125 - template text 61 matched expected
ok 126 - template text 62 processed OK: [% text = 'The cat sat on the ma...
ok 127 - template text 62 matched expected
ok 128 - template text 63 processed OK: <<[% FILTER trim %]\n   \n        ...
ok 129 - template text 63 matched expected
ok 130 - template text 64 processed OK: <<[% FILTER collapse %]\n   \n    ...
ok 131 - template text 64 matched expected
ok 132 - template text 65 processed OK: [% FILTER format('++%s++') %]Hel...
ok 133 - template text 65 matched expected
ok 134 - template text 66 processed OK: [% "my file.html" FILTER uri %]
ok 135 - template text 66 matched expected
ok 136 - template text 67 processed OK: [% "my<file & your>file.html" FI...
ok 137 - template text 67 matched expected
ok 138 - template text 68 processed OK: [% "foo@bar" FILTER uri %]
ok 139 - template text 68 matched expected
ok 140 - template text 69 processed OK: [% "foo@bar" FILTER url %]
ok 141 - template text 69 matched expected
ok 142 - template text 70 processed OK: [% "my<file & your>file.html" | ...
ok 143 - template text 70 matched expected
ok 144 - template text 71 processed OK: [% widetext | uri %]
ok 145 - template text 71 matched expected
ok 146 - template text 72 processed OK: [% 'foobar' | ucfirst %]
ok 147 - template text 72 matched expected
ok 148 - template text 73 processed OK: [% 'FOOBAR' | lcfirst %]
ok 149 - template text 73 matched expected
ok 150 - template text 74 processed OK: [% "foo(bar)" | uri %]
MATCH FAILED
 input: [[% "foo(bar)" | uri %]\n]
expect: [foo(bar)]
output: [foo%28bar%29]
not ok 151 - template text 74 did not match expected
ok 152 - template text 75 processed OK: [% "foo(bar)" | url %]
MATCH FAILED
 input: [[% "foo(bar)" | url %]\n]
expect: [foo(bar)]
output: [foo%28bar%29]
not ok 153 - template text 75 did not match expected
ok 154 - template text 76 processed OK: [% use_rfc3986;\n   "foo(bar)" | ...
ok 155 - template text 76 matched expected
ok 156 - template text 77 processed OK: [% "foo(bar)" | uri %]
ok 157 - template text 77 matched expected
ok 158 - template text 78 processed OK: [% use_rfc2732;\n   "foo(bar)" | ...
ok 159 - template text 78 matched expected
ok 160 - template text 79 processed OK: [% "foo(bar)" | uri %]
ok 161 - template text 79 matched expected
ok 162 - t/test/tmp/xyz exists
Failed 2/162 subtests

Test Summary Report
-------------------
t/filter.t (Wstat: 0 Tests: 162 Failed: 2)
  Failed tests:  151, 153
Files=1, Tests=162,  1 wallclock secs ( 0.05 usr  0.00 sys +  0.14 cusr  0.01 csys =  0.20 CPU)
Result: FAIL
@atoomic atoomic self-assigned this Oct 5, 2018
@atoomic
Copy link
Collaborator Author

atoomic commented Oct 5, 2018

the test was broken when switching URI to RFC3986 by default as part of b0620f4

atoomic added a commit to atoomic/Template2 that referenced this issue Oct 5, 2018
@atoomic
Adjust t/filter.t after using RFC3986 as default for URI
8860360 
GH abw#179

With commit b0620f4 we start using RFC3986 as default
for URI but the test was not adjusted according to this
new setting.
@atoomic atoomic mentioned this issue Oct 5, 2018
Merged
atoomic added a commit to atoomic/Template2 that referenced this issue Oct 5, 2018
@atoomic
Adjust t/filter.t after using RFC3986 as default for URI
ddf24e3 
GH abw#179

With commit b0620f4 we start using RFC3986 as default
for URI but the test was not adjusted according to this
new setting.
@toddr toddr closed this as completed Oct 8, 2018
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Nov 24, 2018
Update to 2.28
4191aa7 
Upstream changes:
Version 2.28 - 11th October 2018
#------------------------------------------------------------------------

* Add and enable Travis CI to track GitHub Pull Requests

* Template is now using GitHub as the official Bug Tracker

* Nicolas R. fixed a circular reference in Template::Plugin::Filter
  abw/Template2#152

* Nicolas R. adjusted group regexes to not be greedy
  abw/Template2#94

* Nicolas R. added unit tests to cover regression from RT 91172
  abw/Template2#122

* Nicolas R. added support for template files having mtime=0
  abw/Template2#102

* Todd Rinaldo fixed rand calls with no args in Math plugin
  abw/Template2#155

* Todd Rinaldo corrected ttree 2.22 logic change
  abw/Template2#148

* Todd Rinaldo turned off automated testing for tests using optional modules
  abw/Template2#156

* Nicolas R. adjusted unit tests to not force Stash::XS

* Nicolas R. added a pre allocated buffer in Stash.xs to avoid malloc/free
  abw/Template2#82

* Nicolas R. optmized Template::Parser by avoiding a dummy sub
  abw/Template2#83

* Nicolas R. optimized Template:Directive by using index
  abw/Template2#84

* Nicolas R. adjust _dotop logic in Stash for perl 5.28 and earlier
  abw/Template2#81

* Todd Rinaldo documented VMethod method called 'item'
  abw/Template2#90

* Nicolas R. adjusted t/filter.t after recent switch to RFC3986
  abw/Template2#179

* Nicolas R. fixed warnings from t/cgi.t
  abw/Template2#178

* Ivan Krylov added STRICT option to ttree
  abw/Template2#81

* Kent Fredric fixed relative path handling in templates on Perl 5.26+
  abw/Template2#80

* Tom Delmas fixed some typo from documentation
  abw/Template2#76

* Matthew Somerville switched uri/url to use RFC3986
  updated the documentation to match the history.
  abw/Template2#35

* Sebastien Deseille used remove_tree helper to remove directories
  abw/Template2#67

* Nick Hibma - Add Sortkeys to DUMPER_ARGS
  abw/Template2#64

* E. Choroba added a warn on duplicate block name
  abw/Template2#61

* Jason Lewis fixed some typo in ttree.pod
  abw/Template2#58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atoomic atoomic

Labels
Test Suite
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@toddr @atoomic