CMake update #1065
CMake update #1065
Conversation
The value of ACADOS_WITH_QORE toggles whether qore include directories are attached to the acados target's. This stops projects not using qore from getting missing-include-dir warnings
- Lets acadosConfig.cmake find OOQP dependencies OpenBLAS and FortranLibs only if ACADOS_WITH_OOQP is set. - Swaps find_package with modern find_dependency in acadosConfig.cmake to let acados propagate find_package args like REQUIRED - Installs acados's own Find*.cmake scripts to let them be found if the user installs to non-default locations by tweaking ACADOS_INSTALL_DIR
|
A second part of this PR addresses a similar issue of optional dependencies leaking and showing warnings to users that consume acados, i.e. even though they appear to be needed by Furthermore, Finally, logic is added in |
|
Just a note: In acados, we decided to squash merge the PRs and use the PR description as the commit message. |
improve readability
|
I complied with the changes you suggested. I had been conservative in wanting to minimize diffs. Changes were divided in two commits was because initially I wanted to just fix qore include dirs only. But then I skimmed the forum and issues and found #1047 and some other issues about people wanting to tweak their Acados install location e.g. system-wide install to /usr/local, which would require cooperation from find_package. I judged the time is ripe and took the liberty to squeeze in a second commit in this PR. |
Adjusting CMAKE_PREFIX_PATH in acadosConfig.cmake breaks dependency handling by catkin when building a ROS package that depends on acados. A similar path adjustment issue had been fixed by acados#953. Said ad-hoc path adjustment is likely made unnecessary by acados#1065, which introduced installing cmake scripts to standard locations.
Adjusting CMAKE_PREFIX_PATH in acadosConfig.cmake breaks dependency handling by catkin when building a ROS package that depends on acados. A similar path adjustment issue had been fixed by acados#971. Said ad-hoc path adjustment is likely made unnecessary by acados#1065, which introduced installing cmake scripts to standard locations.
FindNumpy.cmake,FindMatlab.cmake