Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored optionally verbose system calls in python interface #962

Merged
merged 5 commits into from
Sep 1, 2023

Conversation

tudoroancea
Copy link
Contributor

Pursuing the efforts of PR #928, I refactored all the system calls in the python interface by introducing the following utility function:

def verbose_system_call(cmd, verbose=True):
    return call(
        cmd,
        stdout=None if verbose else DEVNULL,
        stderr=None if verbose else STDOUT
    )

@sandmaennchen
Copy link
Contributor

Hi 👋 changes look good to me, could you rebase on master?

@tudoroancea
Copy link
Contributor Author

@sandmaennchen I just did and some of the unit tests fail, and I don't know why yet. I will investigate it as soon as I manage to get them run locally.
In the meantime, do you have any idea what might make the tests fail?

@sandmaennchen
Copy link
Contributor

Hi, you can reproduce the error by running the examples minimal_example_sim_cmake.py and extensive_example_sim.py.

This call raises the error, not sure why though, running the command string works fine for me.
https://github.com/tudoroancea/acados/blob/e31b8b5e8473ba77ad959e6427292d5702746562/interfaces/acados_template/acados_template/builders.py#L100C1-L100C1

Copy link
Member

@FreyJo FreyJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@sandmaennchen sandmaennchen merged commit 9622cfd into acados:master Sep 1, 2023
3 checks passed
@tudoroancea tudoroancea deleted the ted/more-verbose branch September 1, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants