Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded ARIA #26

Closed
jmuheim opened this issue Mar 17, 2018 · 1 comment
Closed

Remove unneeded ARIA #26

jmuheim opened this issue Mar 17, 2018 · 1 comment
Assignees
@rudigier
Labels
scope: frontend

Comments

@jmuheim
Copy link
Collaborator

jmuheim commented Mar 17, 2018

Remove all role-attributes and replace them with their respective semantic elements, e.g. role="main" should be a <main> container.

Don’t do redundant stuff like <button role="button">. See https://accessibility-developer-guide.netlify.com/knowledge/aria/safe-and-misuse/.
rudigier pushed a commit that referenced this issue Mar 19, 2018
fix: remove unnecessary role attributes. refs #26
912d657
@rudigier
Copy link
Collaborator

Unnecessary role attributes are removed now. Thanks for the input!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rudigier rudigier

Labels
scope: frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmuheim @rudigier