Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next (and previous) links #30

Closed
jmuheim opened this issue Mar 17, 2018 · 5 comments
Closed

Next (and previous) links #30

jmuheim opened this issue Mar 17, 2018 · 5 comments
Assignees
@backflip @rudigier
Labels
scope: build system scope: frontend

Comments

@jmuheim
Copy link
Collaborator

jmuheim commented Mar 17, 2018

A next (and maybe previous) link at the bottom of each page would be great.
backflip added a commit that referenced this issue Mar 17, 2018
@backflip
Added prev/next links, refs #30
bff7ef5
@backflip backflip removed their assignment Mar 17, 2018
@backflip
Copy link
Collaborator

@rudigier, I have added links to the bottom of the main template.

Demo: https://5aad25c77b6ee81f579cbc82--accessibility-developer-guide.netlify.com/setup/windows/modern-ie/

@jmuheim
Copy link
Collaborator Author

jmuheim commented Apr 9, 2018

Thanks for your effort.

But the links only point to the next/previous element on the same level.

For example, Welcome's "next" points to Setup: https://5aad25c77b6ee81f579cbc82--accessibility-developer-guide.netlify.com/welcome/

The previous/next should lead through the whole tree of pages, for example the "next" link of "Web Browsers" should point to "Internet Explorer 11 installation and configuration", while the "previous" link should point to "Internet Explorer 11 installation and configuration": https://5aad25c77b6ee81f579cbc82--accessibility-developer-guide.netlify.com/setup/browsers/

@jmuheim
Copy link
Collaborator Author

jmuheim commented Apr 9, 2018

getting_a_free_windows_virtual_machine_from_modern_ie

jmuheim added a commit that referenced this issue Apr 15, 2018
@jmuheim
Remove previous/next links as long as they're not fully working, see #…
ef475dd 
…30 (comment)
@backflip backflip self-assigned this Apr 18, 2018
backflip added a commit that referenced this issue Apr 18, 2018
@backflip
Fixed prev/next links to work across levels, refs #30
0022fe0
backflip added a commit that referenced this issue Apr 18, 2018
@backflip
Extracted prev/next links into component, added basic styling, refs #30
6606fa5
@backflip
Copy link
Collaborator

Fixed in #45

@jmuheim
Copy link
Collaborator Author

jmuheim commented Apr 18, 2018

@backflip Great! But please use complete title (not short one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@backflip backflip

@rudigier rudigier

Labels
scope: build system scope: frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@backflip @jmuheim @rudigier