This repository has been archived by the owner on Nov 19, 2020. It is now read-only.
Fix calculation of log likelihoods for BaumWelch learning algorithm #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unused variable oldLogLikelihood
- remove re-initialization of newLogLikelihood to -Inf,
which caused only the last sequence in a set of sequences
to be used in the fitness calculation!
cesarsouza
added a commit
that referenced
this pull request
Nov 26, 2014
Fix calculation of log likelihoods for BaumWelch learning algorithm.
|
Thanks! This was introduced after the convergence controlling mechanism was replaced by IConvergence objects. Many thanks for spotting this one! |
cesarsouza
added a commit
that referenced
this pull request
Nov 26, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which caused only the last sequence in a set of sequences
to be used in the fitness calculation!