Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

feat(components): display header on hover - I118 #121

Merged
merged 5 commits into from
Aug 27, 2019
Merged

feat(components): display header on hover - I118 #121

merged 5 commits into from
Aug 27, 2019

Conversation

irmerk
Copy link
Member

@irmerk irmerk commented Aug 27, 2019

Issue #118

Show edit buttons and header only on hover

Changes

  • Created new prop HEADER_TITLE which will be passed through in TSv2
  • Use local state in each clause to have individual hover effect
  • Truncate any header over 54 characters to fit on one line
  • Screenshots to showcase:

With a heading which is short enough to not need truncation:
Screen Shot 2019-08-27 at 10 30 24 AM
With a heading which is too long and needs truncation:
Screen Shot 2019-08-27 at 10 30 53 AM

  • Structure grid system with the following labels:

Screen Shot 2019-08-27 at 10 36 21 AM

Flags

Related Issues

Signed-off-by: irmerk <jolenelanglinais@gmail.com>
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk added the Type: Feature Request 🛍️ New feature or request label Aug 27, 2019
@irmerk irmerk added this to the 0.1.0 milestone Aug 27, 2019
@irmerk irmerk self-assigned this Aug 27, 2019
@irmerk irmerk added this to In Progress PR in Template Studio V2 via automation Aug 27, 2019
@irmerk
Copy link
Member Author

irmerk commented Aug 27, 2019

For reference @Michael-Grover and @mttrbrts

Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo in variable name. otherwise looks good!

src/components/ClauseComponent.js Outdated Show resolved Hide resolved
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk requested a review from DianaLease August 27, 2019 15:59
@irmerk irmerk merged commit be1114c into accordproject:master Aug 27, 2019
Template Studio V2 automation moved this from In Progress PR to Finished PR Aug 27, 2019
@irmerk irmerk deleted the irmerk/i118/clause-hover branch August 27, 2019 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature Request 🛍️ New feature or request
Projects
No open projects
Template Studio V2
  
Finished PR
Development

Successfully merging this pull request may close these issues.

None yet

2 participants