This repository has been archived by the owner on May 19, 2020. It is now read-only.
feat(components) add header tooltip - I120 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: J <johnnyqbui7@gmail.com>
johnnyqbui
force-pushed
the
johnnyqbui-issue120-header-tooltip-feature
branch
from
2d45c3e
to
24b529d
Compare
Signed-off-by: J <johnnyqbui7@gmail.com>
|
I'm not able to reproduce this with your branch. I'm not getting the tooltip nor the truncation being in effect. @DianaLease are you able to? The code looks solid, I may be having version issues on my local machine.
|
|
This works great for me both in the cicero-ui demo and when linked with TSv2. TSv2: cicero-ui: Nice job! |
irmerk
approved these changes
Oct 7, 2019
|
Super cool @johnnyqbui! @Michael-Grover note that this was just merged in. |
|
@johnnyqbui very nice, thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #120
hovering over clause template header title will pop up a tooltip if header has been truncated.
Changes
actionsto utilizetitleGeneratorfunction to display title on tooltip.Flags
Related Issues