added support for read-only rendering

[kanav-raina]

Signed-off-by: kanav kanavraina98@gmail.com

Issue #45

Add Support for read only

Changes

Added a read only prop to input fields

Flags

Related Issues

• Issue #
• Pull Request #

[kanav-raina]

kindly review @irmerk and @mttrbrts.

[mttrbrts]

Great work @kanav-raina, I've found a few small bugs. Can address these too, please, then I'll be happy to merge?

The following fields are not read-only

• Drop-downs (e.g. as in the currency code in PaymentObligation)
• Relationship fields (e.g. as in the Contract Field in PaymentObligation)
• Primitive fields i.e. fields with type String, Boolean, Double, Array etc. (e.g. accelerometerReadings in the DeliveryUpdate example)

[kanav-raina]

Thanks @mttrbrts for the feedback. I will try to fix the bugs in Drop-downs, Relationship fields and
Primitive fields

[kanav-raina]

hello @mttrbrts,
I have defined the readOnly props in packages/concerto-ui-react/src/concertoForm.js and I am using disabled={ props.readOnly }.
By default readOnly is not defined for select and button.
We can achieve this with a little css like
select[readonly] {
pointer-events: none;
touch-action: none;
}

But I think defining readOnly in concertoForm and using it as disabled={ props.readOnly } in reactfromvisitor is more easy. If you want the css solution I will be happy to do it
Thanks!

[mttrbrts]

But I think defining readOnly in concertoForm and using it as disabled={ props.readOnly } in reactfromvisitor is more easy. If you want the css solution I will be happy to do it

I agree, however, can we keep the readOnly behaviour on the input fields that support it (such as text input), then use disabled on select and checkBoxes?

[kanav-raina]

Done
kindly review @mttrbrts

[mttrbrts]

Great, LGTM!

I think that there are several areas where we could improve the design (ideas below), but I'm happy to merge this change and open another issue. What do you think?

• Buttons and Dropdowns could be replaced by a different control when readonly, for example, by a label.
  
• Replace all fields by labels when readOnly. Perhaps this is should be a different property altogether?

[jeromesimeon]

Great, LGTM!

I think that there are several areas where we could improve the design (ideas below), but I'm happy to merge this change and open another issue. What do you think?

• Buttons and Dropdowns could be replaced by a different control when readonly, for example, by a label.
  
• Replace all fields by labels when readOnly. Perhaps this is should be a different property altogether?

Looks nice. Yes for read only, we could probably have something a lot more compact?

[kanav-raina]

Thanks @mttrbrts and @jeromesimeon for the review.

I think that there are several areas where we could improve the design (ideas below), but I'm happy to merge this change and open another issue. What do you think?

@mttrbrts, Kindly merge this pr and open a new issue and assign that to me. I would be happy to work on it