Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadOnly mode should provide a simplified & compact rendering of the form. #13

Closed
mttrbrts opened this issue Apr 22, 2020 · 7 comments · Fixed by #365
Closed

ReadOnly mode should provide a simplified & compact rendering of the form. #13

mttrbrts opened this issue Apr 22, 2020 · 7 comments · Fixed by #365

Comments

@mttrbrts
Copy link
Sponsor Member

Is your feature request related to a problem? Please describe.
As discussed in accordproject/concerto-ui#54, when the readOnly prop is true, it would be convenient for the form fields to be more compact.

Describe the solution you'd like
For example, currently,

  • the buttons and dropdown fields appear as disabled input fields, however it would be more natural for them to be readOnly input fields

Describe alternatives you've considered
Alternatively, all of the fields could be replaced with labels. This is a more fundamental change, and the form would no longer be "a form". This could be an alternative prop, e.g. noFields, textOnly ?

@mttrbrts
Copy link
Sponsor Member Author

@kanav-raina @jeromesimeon

@kanav-raina
Copy link

kanav-raina commented Apr 23, 2020

hello @mttrbrts. I would like to work on it. Kindly assign this to me.
Thanks!

@mttrbrts mttrbrts reopened this Apr 23, 2020
@mttrbrts
Copy link
Sponsor Member Author

Odd, I can't seem to add you! GitHub has been having issues recently, I wonder if it's related?

@kanav-raina kanav-raina removed their assignment May 4, 2020
@irmerk irmerk transferred this issue from accordproject/concerto-ui May 12, 2020
@irmerk irmerk assigned kanav-raina and unassigned kanav-raina May 13, 2020
@irmerk irmerk added this to Triage in Web Components v1.0 via automation May 18, 2020
@irmerk irmerk self-assigned this Sep 16, 2020
@irmerk irmerk removed their assignment Sep 25, 2020
@irmerk irmerk added the hacktoberfest-accepted DigitalOcean's Hacktoberfest 2020 label Sep 25, 2020
@jeromesimeon jeromesimeon self-assigned this Sep 29, 2020
@irmerk irmerk self-assigned this Feb 10, 2021
@irmerk irmerk removed the hacktoberfest-accepted DigitalOcean's Hacktoberfest 2020 label Feb 10, 2021
@Cronus1007
Copy link
Contributor

@mttrbrts Shall I work upon this issue.

@irmerk
Copy link
Member

irmerk commented Mar 11, 2021

I'm currently working on this Issue

@TC5022
Copy link
Contributor

TC5022 commented Dec 15, 2021

if this issue is still open, may I work on it @irmerk ?

@irmerk
Copy link
Member

irmerk commented Dec 21, 2021

Go for it.

Web Components v1.0 automation moved this from Triage to Finished Issue Jan 12, 2022
mttrbrts pushed a commit that referenced this issue Jan 12, 2022
Signed-off-by: TC5022 <tanyac5022002@gmail.com>
AbhijithGanesh pushed a commit to AbhijithGanesh/web-components that referenced this issue Feb 8, 2022
)

Signed-off-by: TC5022 <tanyac5022002@gmail.com>
Signed-off-by: Abhijith Ganesh <g.abhijith14122003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Web Components v1.0
  
Finished Issue
Development

Successfully merging a pull request may close this issue.

6 participants