-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(valuegenerator): Generate valid values for Regex and Range meta properties #178
Merged
mttrbrts
merged 7 commits into
accordproject:release-1.0
from
mttrbrts:mr-generate-validators
Mar 20, 2020
Merged
feat(valuegenerator): Generate valid values for Regex and Range meta properties #178
mttrbrts
merged 7 commits into
accordproject:release-1.0
from
mttrbrts:mr-generate-validators
Mar 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…properties Signed-off-by: Matt Roberts <code@rbrts.uk>
mttrbrts
force-pushed
the
mr-generate-validators
branch
from
March 7, 2020 22:11
d227371
to
f9d6941
Compare
Signed-off-by: Matt Roberts <code@rbrts.uk>
mttrbrts
commented
Mar 7, 2020
jeromesimeon
force-pushed
the
release-1.0
branch
2 times, most recently
from
March 10, 2020 03:25
efeaaf2
to
f7d57a7
Compare
Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Matt Roberts <code@rbrts.uk>
mttrbrts
changed the title
WIP - feat(valuegenerator): Generate valid values for Regex and Range meta properties
feat(valuegenerator): Generate valid values for Regex and Range meta properties
Mar 18, 2020
Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Matt Roberts <code@rbrts.uk>
jeromesimeon
suggested changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Just a small request to document the range generation function.
dselman
approved these changes
Mar 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Signed-off-by: Matt Roberts <code@rbrts.uk>
jeromesimeon
pushed a commit
that referenced
this pull request
Aug 9, 2020
…properties (#178) * feat(valuegenerator): Generate valid values for Regex and Range meta properties Signed-off-by: Matt Roberts <code@rbrts.uk> * chore(resourcevalidator): Backout commented code Signed-off-by: Matt Roberts <code@rbrts.uk> * test(valuegenerator): Add tests for getRange, and getRegex Signed-off-by: Matt Roberts <code@rbrts.uk> * test(instancegenerator): more tests for range an regex Signed-off-by: Matt Roberts <code@rbrts.uk> * test(valuegenerator): More range testing Signed-off-by: Matt Roberts <code@rbrts.uk> * refactor(valuegenerator): Reduce maximum sample Double value Signed-off-by: Matt Roberts <code@rbrts.uk> * docs(valuegenerator): Adds jsdoc comments Signed-off-by: Matt Roberts <code@rbrts.uk>
jeromesimeon
pushed a commit
that referenced
this pull request
Dec 23, 2020
…properties (#178) * feat(valuegenerator): Generate valid values for Regex and Range meta properties Signed-off-by: Matt Roberts <code@rbrts.uk> * chore(resourcevalidator): Backout commented code Signed-off-by: Matt Roberts <code@rbrts.uk> * test(valuegenerator): Add tests for getRange, and getRegex Signed-off-by: Matt Roberts <code@rbrts.uk> * test(instancegenerator): more tests for range an regex Signed-off-by: Matt Roberts <code@rbrts.uk> * test(valuegenerator): More range testing Signed-off-by: Matt Roberts <code@rbrts.uk> * refactor(valuegenerator): Reduce maximum sample Double value Signed-off-by: Matt Roberts <code@rbrts.uk> * docs(valuegenerator): Adds jsdoc comments Signed-off-by: Matt Roberts <code@rbrts.uk>
jeromesimeon
pushed a commit
that referenced
this pull request
Jan 7, 2021
…properties (#178) * feat(valuegenerator): Generate valid values for Regex and Range meta properties Signed-off-by: Matt Roberts <code@rbrts.uk> * chore(resourcevalidator): Backout commented code Signed-off-by: Matt Roberts <code@rbrts.uk> * test(valuegenerator): Add tests for getRange, and getRegex Signed-off-by: Matt Roberts <code@rbrts.uk> * test(instancegenerator): more tests for range an regex Signed-off-by: Matt Roberts <code@rbrts.uk> * test(valuegenerator): More range testing Signed-off-by: Matt Roberts <code@rbrts.uk> * refactor(valuegenerator): Reduce maximum sample Double value Signed-off-by: Matt Roberts <code@rbrts.uk> * docs(valuegenerator): Adds jsdoc comments Signed-off-by: Matt Roberts <code@rbrts.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #171
Adds functions that generate valid range and regex values when generating sample and empty instance JSON values.