Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(valuegenerator): Generate valid values for Regex and Range meta properties #178

Merged
merged 7 commits into from
Mar 20, 2020

Conversation

mttrbrts
Copy link
Sponsor Member

@mttrbrts mttrbrts commented Mar 7, 2020

Issue #171

Adds functions that generate valid range and regex values when generating sample and empty instance JSON values.

@mttrbrts mttrbrts self-assigned this Mar 7, 2020
…properties

Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Matt Roberts <code@rbrts.uk>
@jeromesimeon jeromesimeon force-pushed the release-1.0 branch 2 times, most recently from efeaaf2 to f7d57a7 Compare March 10, 2020 03:25
Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts marked this pull request as ready for review March 18, 2020 13:52
Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts changed the title WIP - feat(valuegenerator): Generate valid values for Regex and Range meta properties feat(valuegenerator): Generate valid values for Regex and Range meta properties Mar 18, 2020
Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Matt Roberts <code@rbrts.uk>
Copy link
Member

@jeromesimeon jeromesimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a small request to document the range generation function.

Copy link
Sponsor Contributor

@dselman dselman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts merged commit 916aab5 into accordproject:release-1.0 Mar 20, 2020
@mttrbrts mttrbrts deleted the mr-generate-validators branch March 20, 2020 08:10
jeromesimeon pushed a commit that referenced this pull request Aug 9, 2020
…properties (#178)

* feat(valuegenerator): Generate valid values for Regex and Range meta properties

Signed-off-by: Matt Roberts <code@rbrts.uk>

* chore(resourcevalidator): Backout commented code

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(valuegenerator): Add tests for getRange, and getRegex

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(instancegenerator): more tests for range an regex

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(valuegenerator): More range testing

Signed-off-by: Matt Roberts <code@rbrts.uk>

* refactor(valuegenerator): Reduce maximum sample Double value

Signed-off-by: Matt Roberts <code@rbrts.uk>

* docs(valuegenerator): Adds jsdoc comments

Signed-off-by: Matt Roberts <code@rbrts.uk>
jeromesimeon pushed a commit that referenced this pull request Dec 23, 2020
…properties (#178)

* feat(valuegenerator): Generate valid values for Regex and Range meta properties

Signed-off-by: Matt Roberts <code@rbrts.uk>

* chore(resourcevalidator): Backout commented code

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(valuegenerator): Add tests for getRange, and getRegex

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(instancegenerator): more tests for range an regex

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(valuegenerator): More range testing

Signed-off-by: Matt Roberts <code@rbrts.uk>

* refactor(valuegenerator): Reduce maximum sample Double value

Signed-off-by: Matt Roberts <code@rbrts.uk>

* docs(valuegenerator): Adds jsdoc comments

Signed-off-by: Matt Roberts <code@rbrts.uk>
jeromesimeon pushed a commit that referenced this pull request Jan 7, 2021
…properties (#178)

* feat(valuegenerator): Generate valid values for Regex and Range meta properties

Signed-off-by: Matt Roberts <code@rbrts.uk>

* chore(resourcevalidator): Backout commented code

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(valuegenerator): Add tests for getRange, and getRegex

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(instancegenerator): more tests for range an regex

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(valuegenerator): More range testing

Signed-off-by: Matt Roberts <code@rbrts.uk>

* refactor(valuegenerator): Reduce maximum sample Double value

Signed-off-by: Matt Roberts <code@rbrts.uk>

* docs(valuegenerator): Adds jsdoc comments

Signed-off-by: Matt Roberts <code@rbrts.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants