Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): missing array modifier for scalar fields #746

Merged
merged 7 commits into from
Oct 24, 2023
Merged

fix(core): missing array modifier for scalar fields #746

merged 7 commits into from
Oct 24, 2023

Conversation

KrishnaPG
Copy link
Contributor

@KrishnaPG KrishnaPG commented Oct 23, 2023 •
edited
Loading

Closes #745

Changes

  • added array modifier for scalar field unboxing condition

Flags

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@KrishnaPG KrishnaPG requested a review from a team October 23, 2023 02:20
@KrishnaPG
Fix: missing array modifier for scalar fields
cc05deb 
accordproject#346
Signed-off-by: Gopalakrishna Palem <KrishnaPG@Yahoo.com>
mttrbrts
mttrbrts reviewed Oct 23, 2023
View reviewed changes
Copy link
Sponsor Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, GK. Are you able to add a test too, please?

@KrishnaPG
Copy link
Contributor Author

@mttrbrts Tried adding few tests. Please review.

@mttrbrts
Copy link
Sponsor Member

@mttrbrts Tried adding few tests. Please review.

Looking good, thanks! A couple of linting failures. But I'm happy to merge once those are fixed

@KrishnaPG
Copy link
Contributor Author

Fixed the lint issues. Thanks.

@mttrbrts mttrbrts enabled auto-merge (squash) October 23, 2023 11:35
mttrbrts
mttrbrts approved these changes Oct 23, 2023
View reviewed changes
Copy link
Sponsor Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first PR @KrishnaPG 🎉

We should get a release out in the next few days.

@mttrbrts mttrbrts changed the title Fix: missing array modifier for scalar fields fix(core): missing array modifier for scalar fields Oct 23, 2023
@mttrbrts
test(scalar): fix array test for scalars
bf0509c 
Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts enabled auto-merge (squash) October 24, 2023 16:00
@mttrbrts mttrbrts merged commit 96002a1 into accordproject:main Oct 24, 2023
13 checks passed
@KrishnaPG KrishnaPG deleted the patch-1 branch October 25, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSON Schema output is not working for Scalar Arrays
2 participants
@KrishnaPG @mttrbrts