Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(*): v4 #762

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat!(*): v4 #762

wants to merge 7 commits into from

Conversation

mttrbrts
Copy link
Member

@mttrbrts mttrbrts commented Nov 19, 2023

A working branch for all breaking changes that are queued up for the v4.0 release as per the Roadmap.

Changes

Flags

  • The PR contains multiple breaking changes.
  • See the PR notes for individual changes for details
  • This PR should NOT be squashed.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

* v4.0.0-alpha.0

* feat!(*): strict by default

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(*): version everything

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test(*): fix more tests

Signed-off-by: Matt Roberts <code@rbrts.uk>

* refactor(core): modelfile logic for isImportedType

Signed-off-by: Matt Roberts <code@rbrts.uk>

---------

Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts added this to the v4.0 milestone Nov 19, 2023
* chore!(core): migrate to TS project

Signed-off-by: Matt Roberts <code@rbrts.uk>

* chore!(*): migrate vocab, util and cto packages to TS projects

Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix(deps): npm-run-all

Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix(*): code coverage

Signed-off-by: Matt Roberts <code@rbrts.uk>

* chore(*): migrate to npm workspaces

Signed-off-by: Matt Roberts <code@rbrts.uk>

---------

Signed-off-by: Matt Roberts <code@rbrts.uk>

fix(*): fix buggy merge conflicts

Signed-off-by: Matt Roberts <code@rbrts.uk>

fix(build): topological sort of packages

Signed-off-by: Matt Roberts <code@rbrts.uk>

fix(build): topological sort of package names 2

Signed-off-by: Matt Roberts <code@rbrts.uk>
* fix(core): detect ambiguous imports / declarations

Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix(lint): assetdeclaration

Signed-off-by: Matt Roberts <code@rbrts.uk>

---------

Signed-off-by: Matt Roberts <code@rbrts.uk>
@mttrbrts mttrbrts mentioned this pull request Mar 6, 2024
dselman and others added 3 commits March 6, 2024 11:23
* feat(api) refactor api for ergonomics and type safety

Signed-off-by: Dan Selman <danscode@selman.org>

* regen types

Signed-off-by: Dan Selman <danscode@selman.org>

* wip

Signed-off-by: Matt Roberts <code@rbrts.uk>

* test: fix tests for concerto-core

Signed-off-by: Dan Selman <danscode@selman.org>

* test: fix tests

Signed-off-by: Dan Selman <danscode@selman.org>

* test: fix tests

Signed-off-by: Dan Selman <danscode@selman.org>

* fix: tests

Signed-off-by: Dan Selman <danscode@selman.org>

* chore: reduce code cov

Signed-off-by: Dan Selman <danscode@selman.org>

* chore: code cov

Signed-off-by: Dan Selman <danscode@selman.org>

---------

Signed-off-by: Dan Selman <danscode@selman.org>
Signed-off-by: Matt Roberts <code@rbrts.uk>
Co-authored-by: Matt Roberts <code@rbrts.uk>
* fix(build): include unions in index

Signed-off-by: Matt Roberts <code@rbrts.uk>

* chore(deps): upgrade codegen to latest release

Signed-off-by: Matt Roberts <code@rbrts.uk>

---------

Signed-off-by: Matt Roberts <code@rbrts.uk>

* fix(class): throw error when class is extending itself (#767)

* fix(parser): throw error when concept is extending itself in CTO

Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>

* fix(parser): throw error when concept is extending itself in JSON metamodel form

Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>

* fix(parser): throw error when concept is extending itself in the AST

Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>

* refactor(validation): alphabetical rearrangement

Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>

* test(self-extending): remove redundant tests (codepath covered in concerto-cto)

Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>

* test(fix): remove unneeded import

Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>

---------

Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>
Co-authored-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>

* fix(class-declaration): throw with undefined ast properties (#771)

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* fix(error): adding type to error in string validator in introspect (#773)

* fix(error): adding type to error in string validator in introspect

Signed-off-by: Santanu Roy <edu.santanu12@gmail.com>
Co-authored-by: Santanu Roy <santanu.roy@docusign.com>

* refactor(declarations): move declaration uniqueness check to model file (#794)

* refactor(declarations): Move unique name check to model file.

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* refactor(test): move validation checks for duplicate class to model file

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* test: empty commit to trigger test

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

---------

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* perf(core): don't use arrays to check uniqueness (#802)

refactor: don't use arrays to check uniqueness

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* perf(core): remove usage of arrays while forming duplicate item errors (#804)

* refactor: don't use arrays to check uniqueness

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* refactor: also refactor unique property name check

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* refactor: remove array for decorator uniqueness check

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

* refactor: remove uniqueness check from scalar declarations as well

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

---------

Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>

---------

Signed-off-by: Matt Roberts <code@rbrts.uk>
Signed-off-by: Stefan Blaginov <stefanblaginov@gmail.com>
Signed-off-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>
Signed-off-by: Ertugrul Karademir <ekarademir@gmail.com>
Signed-off-by: Santanu Roy <edu.santanu12@gmail.com>
Co-authored-by: Stefan Blaginov <stefanblaginov@gmail.com>
Co-authored-by: Stefan Blaginov <Stefan.Blaginov@docusign.com>
Co-authored-by: Ertugrul Karademir <ekarademir@gmail.com>
Co-authored-by: Santanu Roy <43335319+santanu8961@users.noreply.github.com>
Co-authored-by: Santanu Roy <santanu.roy@docusign.com>
fix(cto): allow imports with semver build and prerelease parts

Signed-off-by: Matt Roberts <code@rbrts.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants