Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

fix(CI) Should use npm install before publish to get external models #806

Merged
merged 1 commit into from Apr 9, 2021
Merged

fix(CI) Should use npm install before publish to get external models #806

merged 1 commit into from Apr 9, 2021

Conversation

jeromesimeon
Copy link
Member

Signed-off-by: Jerome Simeon jeromesimeon@me.com

Changes

  • GitHub workflow should use npm ci rather than lerna bootstrap or it won't get external models

@jeromesimeon
fix(CI) Should use npm install before publish to get external models
eb1da76 
Signed-off-by: Jerome Simeon <jeromesimeon@me.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.376% when pulling eb1da76 on js-fix-publish-without-externals into 4ca4411 on master.

@jeromesimeon jeromesimeon merged commit bc450cf into master Apr 9, 2021
@jeromesimeon jeromesimeon mentioned this pull request Apr 9, 2021
Merged
@jeromesimeon jeromesimeon deleted the js-fix-publish-without-externals branch April 10, 2021 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeromesimeon @coveralls