Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Hyperlink Tooltip #100

Closed
irmerk opened this issue Oct 3, 2019 · 7 comments
Closed

Hyperlink Tooltip #100

irmerk opened this issue Oct 3, 2019 · 7 comments
Assignees
Labels
Difficulty: Medium Good First Issue :octocat: Good for newcomers Hacktoberfest by DigitalOcean and DEV Type: Feature Request 🛍️ New feature or request
Milestone

Comments

@irmerk
Copy link
Member

irmerk commented Oct 3, 2019

Is your feature request related to a problem? Please describe.
We need to style hyperlink text in the document, as well as create a popup tooltip for setting the link.

Describe the solution you'd like
There should be a popup tooltip similar to the one used in Google Docs. Use this as a vague reference, we are not looking to exactly copy it.

Screen Shot 2019-10-03 at 15 17 51 PM

Describe alternatives you've considered
N/A

Additional context
The tooltip that pops up for buttons in the toolbar currently were implemented in PR #66

@irmerk irmerk added Type: Feature Request 🛍️ New feature or request Good First Issue :octocat: Good for newcomers Difficulty: Medium Hacktoberfest by DigitalOcean and DEV labels Oct 3, 2019
@irmerk irmerk added this to the 1.0.0 milestone Oct 3, 2019
@irmerk irmerk added this to Open Issues in Hacktoberfest 2019 via automation Oct 3, 2019
@ahmedkrmn
Copy link

Can I work on this?

@irmerk irmerk added Good First Issue (Taken) and removed Good First Issue :octocat: Good for newcomers labels Oct 4, 2019
@irmerk irmerk moved this from Open Issues to In Progress Issues in Hacktoberfest 2019 Oct 4, 2019
@ahmedkrmn
Copy link

ahmedkrmn commented Oct 5, 2019

Hi @irmerk, just a quick question to make sure I'm on the right track.
Currently the link pop up is a JavaScript alert that looks as follows:

Add Link:

link
Add Text:

text


What you mean by "Hyperlink Tooltip" is that you want to replace the two alerts with a single popup that looks similar to the one used in Google Docs?

@irmerk
Copy link
Member Author

irmerk commented Oct 5, 2019

@ahmedkrmn yes, that's what I was thinking. And again, doesn't need to be specifically like Google Docs, that's just an example. But definitely moving away from the alert style and more of a popup with text fields.

@ahmedkrmn
Copy link

@irmerk Can I use an npm React component or a JavaScript package, or should the new code be entirely written from scratch in JavaScript/CSS ?

@irmerk
Copy link
Member Author

irmerk commented Oct 5, 2019

I'd hesitate to implement new libraries, especially if it's for this one component. We are utilizing styled-components and CSS Grid so far, though.

@irmerk irmerk added Good First Issue :octocat: Good for newcomers and removed Good First Issue (Taken) labels Oct 18, 2019
@irmerk irmerk moved this from In Progress Issues to Open Issues in Hacktoberfest 2019 Oct 18, 2019
@irmerk
Copy link
Member Author

irmerk commented Oct 18, 2019

This is open again. Any other contributor should view #108 as a starting point or for some context.

@sahalsaad
Copy link
Contributor

Hi! I'll work on this issue. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: Medium Good First Issue :octocat: Good for newcomers Hacktoberfest by DigitalOcean and DEV Type: Feature Request 🛍️ New feature or request
Projects
No open projects
Hacktoberfest 2019
  
Finished Issues
Development

No branches or pull requests

3 participants