Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

feat(*): ap design sync - I35 #66

Merged
merged 13 commits into from
Jul 3, 2019
Merged

feat(*): ap design sync - I35 #66

merged 13 commits into from
Jul 3, 2019

Conversation

irmerk
Copy link
Member

@irmerk irmerk commented Jun 27, 2019 •
edited
Loading

Issue #35

Changing styling based on props to fit non-branding and AP-branding

Changes

  • Remove unnecessary Semantic-UI-React Card's
  • Restructure file organization for FormatToolbar
  • Implement more method modularization
  • Add tooltip with logic for determining text to display
  • Update documentation to represent styling options for users
  • Follow a system for optional props from TSv2

Flags

  • Tooltip may need changes to styling or even a DIY version

Related Issues

@irmerk
chore(package): update package - I35
6895207 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): pause for adjustments to prop styling - I35
f52f168 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(SlateAsInputEditor): pause to remove card layers - I35
c63d7c7 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk added the Type: Feature Request 🛍️ New feature or request label Jun 27, 2019
@irmerk irmerk self-assigned this Jun 27, 2019
This was referenced Jun 27, 2019
Merged
Merged
@irmerk
feat(FormatToolbar): begin to implement conditional styling - I35
2237384 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(SlateAsInputEditor): begin to implement conditional styling - I35
948b23c 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(FormatToolbar): merge all additions to new directory - I35
9b63ae0 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(src): delete migrated files - I35
7a50aae 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(SlateAsInputEditor): adjust imports - I35
f6a3b9d 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(examples): adjust demo to render with props - I35
13fc844 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
docs(README): information on styling - I35
2c38e2e 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk marked this pull request as ready for review July 2, 2019 19:59
@irmerk
feat(FormatToolbar): protect from no props passed - I35
74b9957 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
DianaLease
DianaLease suggested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments. Looks great!

src/FormatToolbar/FormatToolbar.js Outdated Show resolved Hide resolved
src/SlateAsInputEditor/index.js Outdated Show resolved Hide resolved
src/SlateAsInputEditor/index.js Outdated Show resolved Hide resolved
@DianaLease DianaLease added this to In Progress PR in Template Studio V2 via automation Jul 2, 2019
@irmerk
refactor(src): adjust naming imports - I35
b61ee97 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
style(SlateAsInputEditor): revert to default css values - I35
8a5cd4b 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk merged commit c7a3945 into accordproject:master Jul 3, 2019
Template Studio V2 automation moved this from In Progress PR to Finished PR Jul 3, 2019
@irmerk irmerk deleted the jl-issue35-sticky-toolbar branch July 3, 2019 14:09
This was referenced Oct 3, 2019
Closed
Closed
@irmerk irmerk mentioned this pull request Oct 4, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DianaLease DianaLease DianaLease approved these changes

@dselman dselman Awaiting requested review from dselman

@jeromesimeon jeromesimeon Awaiting requested review from jeromesimeon

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

Assignees

@irmerk irmerk

Labels
Type: Feature Request 🛍️ New feature or request
Projects
No open projects
Template Studio V2
  
Finished PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irmerk @DianaLease