feat(FormattingToolbar): implement hyperlink tooltip - I100

[sahalsaad]

Issue #100

Replace js alert when setting the link to use popup

Changes

Flags

• Not sure why the selection color gone once I select the text input.

[jolanglinais]

Flagging @Michael-Grover for this as well.

[jolanglinais]

Not sure why the selection color gone once I select the text input.

What do you mean by this?

[sahalsaad]

Not sure why the selection color gone once I select the text input.

What do you mean by this?

In previous PR. @DianaLease mention this.

[jolanglinais]

Regarding all of #142 (comment), I think this is an improvement and could be merged and then iterated upon to improve further. Thoughts @DianaLease?

[DianaLease]

Regarding all of #142 (comment), I think this is an improvement and could be merged and then iterated upon to improve further. Thoughts @DianaLease?

Yes, I agree. Looks good!

[jolanglinais]

@sahalsaad I'm also noticing that you need to right click to open the link.

[Michael-Grover]

@sahalsaad This looks great, thank you for taking this issue. Can you change the form field descriptions and placeholder text to the following:

Link Text
Text

Link URL
https://example.com

Would it be possible for this UI to be placed above or below the text, so that it is easier for the user to tell which text is becoming a Hyperlink? See this example from Google Docs
image

[sahalsaad]

@sahalsaad This looks great, thank you for taking this issue. Can you change the form field descriptions and placeholder text to the following:

Link Text
Text

Link URL
https://example.com

The text and placeholder already correct. Refer index.js line 293-298.

Would it be possible for this UI to be placed above or below the text, so that it is easier for the user to tell which text is becoming a Hyperlink? See this example from Google Docs
image

Sorry. I spent some time to research on that but not able to do it.
I don't have much knowledge on slate.js.

[sahalsaad]

@sahalsaad I'm also noticing that you need to right click to open the link.

Which link? Is it different from current behavior?

[jolanglinais]

These are some issues I will file which seem a bit separate - this is an improvement on what currently exists.