Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: export transformers from markdown-docx root #402

Merged
merged 1 commit into from Jun 11, 2021

Conversation

K-Kumar-01
Copy link
Collaborator

@K-Kumar-01 K-Kumar-01 commented Jun 11, 2021

Signed-off-by: k-kumar-01 kushalkumargupta4@gmail.com

While working on this PR, refactoring was done. As a result, the require() statements required changes that were missed. This PR aims at that.

Changes

  • Add CiceroMarkToOOXMLTransformer
  • Fix typo OoxmlTransformer require
  • Deleted index.js(src) as the files were already being imported from the lib folder.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

Add CiceroMarkToOOXMLTransformer
Fix typo OoxmlTransformer require

Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
@K-Kumar-01
Copy link
Collaborator Author

@algomaster99
Seems like it fails on windows. But I am unable to understand the reason for that. Though on Ubuntu it passes succesfully.

@algomaster99
Copy link
Member

algomaster99 commented Jun 11, 2021

The tests are failing because of the line endings. Run the following commands and push the changes.

git config core.eol lf
git config core.autocrlf true

@K-Kumar-01 refer to this documentation. Read the description of core.aurocrlf. You will understand why builds are failing.

EDIT
Don't bother with the above commands. Some other package is interfering.

@algomaster99 algomaster99 changed the title typo:change require statement refactor: export transformers from markdown-docx root Jun 11, 2021
@algomaster99 algomaster99 merged commit 7b72770 into algoo-ooxml Jun 11, 2021
@algomaster99 algomaster99 deleted the k-kumar-01/i397/export-typo branch June 11, 2021 17:43
algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
algomaster99 pushed a commit that referenced this pull request Jun 17, 2021
Signed-off-by: k-kumar-01 <kushalkumargupta4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants