feat(markdown-docx): add inline-code transformer - #397 #426
Conversation
Inline code transformation: CiceroMark<->OOXML Test for the above Signed-off-by: K-Kumar-01 <kushalkumargupta4@gmail.com>
K-Kumar-01
changed the title
| if (runTimeProperties.attributes['w:val'] === 'C45911') { | ||
| colorCodePresent = true; | ||
| } | ||
| } else if (runTimeProperties.name === 'w:highlight') { | ||
| if (runTimeProperties.attributes['w:val'] === 'lightGray') { |
There was a problem hiding this comment.
TemplateMark Dingus uses #C7254E and #F9F2F4 for color and highlight respectively. I think it would make sense if we are consistent.
There was a problem hiding this comment.
@algomaster99 We can change the color but for highlighting I am afraid as word supports limited highlighting colors.
Image when color is changed to C7254E.
Should I change the color with respect to above image?
There was a problem hiding this comment.
Just making sure here. Highlight colour is the background colour while the simply "colour" is the font colour, right?
There was a problem hiding this comment.
MS Word itself doesn't have limited colours for font-colour so it's quite tough to understand changing color to #C7254E is not possible.
There was a problem hiding this comment.
Just making sure here. Highlight colour is the background colour while the simply "colour" is the font colour, right?
Yes
There was a problem hiding this comment.
MS Word itself doesn't have limited colours for font-colour so it's quite tough to understand changing color to
#C7254Eis not possible.
I am not sure as when I changed the color in OOXML to #C7254E it gave no errors. So I assumed that it might pe possible.
There was a problem hiding this comment.
@algomaster99
So should we keep the colors as it is? I mean no changes in text or highlight color.
There was a problem hiding this comment.
I tried to tweak colours myself and it turns out that you can change the font color to any RGB colour however, highlight colour only takes specific values which are listed in the link I have linked below.
<w:r>
<w:rPr>
<w:color w:val="C7254E" />
<w:shd w:fill="F9F2F4"/>
</w:rPr>
<w:t>Inline code</w:t>
</w:r>You can try to generate an OOXML like above to achieve the desired effect.
Reference: http://officeopenxml.com/WPtextShading.php.
There was a problem hiding this comment.
@algomaster99 will update the PR ASAP.
There was a problem hiding this comment.
@algomaster99
Done
Signed-off-by: K-Kumar-01 <kushalkumargupta4@gmail.com>
| if (runTimeProperties.attributes['w:val'] === 'C7254E') { | ||
| colorCodePresent = true; | ||
| } | ||
| } else if (runTimeProperties.name === 'w:shd') { |
There was a problem hiding this comment.
Just comment here why you are using shd instead of highlight.
There was a problem hiding this comment.
Can you give insights here?
According to me
Limited highlighting in word so use shade for highlting.
There was a problem hiding this comment.
w:shd tag is used to detect the highlight colour of the text. w:highlight is not used for this purpose because of its ability to render fixed colours. Reference: http://officeopenxml.com/WPtextShading.php.
Signed-off-by: K-Kumar-01 <kushalkumargupta4@gmail.com>
Signed-off-by: Aman Sharma <mannu.poski10@gmail.com>
Signed-off-by: K-Kumar-01 kushalkumargupta4@gmail.com
Add the roundtrip transformation i.e.
CiceroMark<->OOXMLtransformation forinline-code.Changes
Screenshots or Video
Author Checklist
--signoffoption of git commit.masterfromfork:branchname