Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

feat(*): ap design sync - I57 #58

Merged
merged 13 commits into from
Jul 3, 2019
Merged

feat(*): ap design sync - I57 #58

merged 13 commits into from
Jul 3, 2019

Conversation

irmerk
Copy link
Member

@irmerk irmerk commented Jun 27, 2019 •
edited
Loading

Issue #57

Changing styling based on props to fit non-branding and AP-branding

Changes

  • Remove unnecessary Semantic-UI-React Card's
  • Follow a system for styling props to pass through to Cicero-UI

Flags

  • Possible styling issue with the Contract Editor's scrollbar when extending past the bottom of the page

Related Issues

@irmerk
feat(App): sync styling for all components - I57
f1dd985 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(LeftNav): implement ap styling - I57
94bcde2 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
style(Header): adjust app header boldness - I57
52f55ea 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(ContractEditor): sync styling with other components - I57
47578fe 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(TemplateLibrary): sync ap style with explicit props - I57
d3444e1 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(package): package lock - I57
1c8e7a5 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk added the Type: Feature Request 🛍️ New feature or request label Jun 27, 2019
@irmerk irmerk self-assigned this Jun 27, 2019
This was referenced Jun 27, 2019
Merged
Merged
@irmerk
feat(App): implement style theme constants - I57
352f5de 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
feat(*): begin to implement style theme constants throughout app - I57
859a579 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
chore(test): update snapshots - I57
95831af 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
refactor(App): adjust theme constants - I57
254586b 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk
refactor(src): implement theme constant system - I57
cdcc409 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk marked this pull request as ready for review July 2, 2019 19:59
DianaLease
DianaLease suggested changes Jul 2, 2019
View reviewed changes
Copy link
Member

@DianaLease DianaLease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, just a couple small comments!

src/components/TextButton.js Outdated Show resolved Hide resolved
src/containers/App/themeConstants.js Outdated Show resolved Hide resolved
@DianaLease DianaLease added this to In Progress PR in Template Studio V2 via automation Jul 2, 2019
@irmerk
chore(src): remove excess comments - I57
6b963c0 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
DianaLease
DianaLease previously approved these changes Jul 3, 2019
View reviewed changes
@irmerk
chore(package): increment accordproject dependencies - I57
9e5c83a 
Signed-off-by: irmerk <jolenelanglinais@gmail.com>
@irmerk irmerk requested a review from DianaLease July 3, 2019 15:06
@irmerk irmerk merged commit c3817f1 into accordproject:master Jul 3, 2019
Template Studio V2 automation moved this from In Progress PR to Finished PR Jul 3, 2019
@irmerk irmerk deleted the jl-issue57-ap-theme branch July 3, 2019 15:12
This was referenced Jul 3, 2019
Closed
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dselman dselman Awaiting requested review from dselman

@jeromesimeon jeromesimeon Awaiting requested review from jeromesimeon

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

@DianaLease DianaLease Awaiting requested review from DianaLease

Assignees

@irmerk irmerk

Labels
Type: Feature Request 🛍️ New feature or request
Projects
No open projects
Template Studio V2
  
Finished PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@irmerk @DianaLease