Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui-concerto): add textOnly mode-#13 #365

Merged
merged 1 commit into from
Jan 12, 2022
Merged

feat(ui-concerto): add textOnly mode-#13 #365

merged 1 commit into from
Jan 12, 2022

Conversation

TC5022
Copy link
Contributor

@TC5022 TC5022 commented Jan 11, 2022

Signed-off-by: TC5022 tanyac5022002@gmail.com

Closes #13

Added a text-only prop that provides a succinct version of the concerto-form so that it is compact and easier to read.

Changes

Props added:
textOnly- builds on the readOnly prop and provides a compact view
Changed all the form fields including inputs, dropdowns, checkboxes, array elements, etc. Furthermore, styled the input fonts and colors so that it is convenient for the user to go through and read the form.

Screenshots or Video

image

image

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@TC5022
Copy link
Contributor Author

TC5022 commented Jan 11, 2022

Requesting a review @mttrbrts

Signed-off-by: TC5022 <tanyac5022002@gmail.com>
Copy link
Sponsor Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and congratulations on your first PR! 🌟

@TC5022
Copy link
Contributor Author

TC5022 commented Jan 12, 2022

Thanks a lot!

@mttrbrts mttrbrts merged commit 1986f1e into accordproject:master Jan 12, 2022
@irmerk
Copy link
Member

irmerk commented Jan 12, 2022

👏🏻

@TC5022 TC5022 deleted the TC5022/i13/textOnly-mode branch January 19, 2022 17:06
AbhijithGanesh pushed a commit to AbhijithGanesh/web-components that referenced this pull request Feb 8, 2022
)

Signed-off-by: TC5022 <tanyac5022002@gmail.com>
Signed-off-by: Abhijith Ganesh <g.abhijith14122003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReadOnly mode should provide a simplified & compact rendering of the form.
3 participants