Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations are not 100% #340

Closed
EinKantHolz opened this issue Jun 11, 2024 · 3 comments · Fixed by #346
Closed

Translations are not 100% #340

EinKantHolz opened this issue Jun 11, 2024 · 3 comments · Fixed by #346
Assignees
Labels
Current Release! Related to the most recent (public) release improvement This is an improvement

Comments

@EinKantHolz
Copy link

EinKantHolz commented Jun 11, 2024

Just want to know if it's a bug or a missing "feature": I set all my modules to "de" language but there are some words which are not translated.

  • The Weater module: Every day is in english
  • The Agenda module: for all day entries it says "all day" instead of "ganztags" or similar in german.

Can i modifiy those translations by myself and if so, where?

EDIT: I found a bug while using the token "DD. MMMM YYYY" > It displays only "11. Juni 202" - the 4 is missing.
One has to use YYYYY (5x Y for 2024).

Copy link

Hi there and welcome to Inkycal. Thanks for opening this issue. As this is your first issue in this repository, please read through the contributing guidelines

@aceisace aceisace self-assigned this Jun 11, 2024
@aceisace aceisace added improvement This is an improvement Current Release! Related to the most recent (public) release labels Jun 11, 2024
@aceisace
Copy link
Member

Hi @EinKantHolz and thanks for reporting this issue. I will take care of this soon 👍 . Meanwhile, if you notice any other missing translations, please post them here

@aceisace
Copy link
Member

I've implemented the suggestions by these changes:

  • Add MaterialIcons font
  • Use icon for all-day events on Agenda module as translating "all-day" is pretty complicated without bloating the code and additional dependencies
  • Fix missing translations, e.g. weekday on daily weather forecast

The PR for this is on the way, once the tests have passed, I kindly ask you to test the changes to ensure it's working as expected

@aceisace aceisace linked a pull request Jun 22, 2024 that will close this issue
aceisace added a commit that referenced this issue Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Current Release! Related to the most recent (public) release improvement This is an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants